From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Fixing non-blocking operation of chardevs
Date: Fri, 1 Apr 2016 12:45:43 +0200 [thread overview]
Message-ID: <56FE5157.8020500@redhat.com> (raw)
In-Reply-To: <1459438168-8146-1-git-send-email-berrange@redhat.com>
On 31/03/2016 17:29, Daniel P. Berrange wrote:
> This fixes socket chardevs to always be in non-blocking
> mode, as they were before the QIOChannel conversion. The
> second patch was already posted before, but dropped when
> Peter discovered a problem on OS-X causing ahci-test to
> hang:
>
> https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg05807.html
>
> I traced this down to broken EAGAIN handling affecting
> OS-X, hence the first patch in this series.
>
> Changed in v2:
>
> - Also fix qemu_chr_fe_write_log method
>
> Daniel P. Berrange (2):
> char: fix broken EAGAIN retry on OS-X due to errno clobbering
> char: ensure all clients are in non-blocking mode
>
> qemu-char.c | 39 ++++++++++++++++++++-------------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
Thanks, queued for the next pull request (next week).
Paolo
prev parent reply other threads:[~2016-04-01 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 15:29 [Qemu-devel] [PATCH v2 0/2] Fixing non-blocking operation of chardevs Daniel P. Berrange
2016-03-31 15:29 ` [Qemu-devel] [PATCH v2 1/2] char: fix broken EAGAIN retry on OS-X due to errno clobbering Daniel P. Berrange
2016-03-31 15:29 ` [Qemu-devel] [PATCH v2 2/2] char: ensure all clients are in non-blocking mode Daniel P. Berrange
2016-04-01 10:45 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE5157.8020500@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).