From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwbA-0007Vs-DK for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:46:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alwb7-0002Zx-7P for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:46:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwb7-0002Zi-2T for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:46:37 -0400 References: <1459438168-8146-1-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: <56FE5157.8020500@redhat.com> Date: Fri, 1 Apr 2016 12:45:43 +0200 MIME-Version: 1.0 In-Reply-To: <1459438168-8146-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] Fixing non-blocking operation of chardevs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Peter Maydell On 31/03/2016 17:29, Daniel P. Berrange wrote: > This fixes socket chardevs to always be in non-blocking > mode, as they were before the QIOChannel conversion. The > second patch was already posted before, but dropped when > Peter discovered a problem on OS-X causing ahci-test to > hang: > > https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg05807.html > > I traced this down to broken EAGAIN handling affecting > OS-X, hence the first patch in this series. > > Changed in v2: > > - Also fix qemu_chr_fe_write_log method > > Daniel P. Berrange (2): > char: fix broken EAGAIN retry on OS-X due to errno clobbering > char: ensure all clients are in non-blocking mode > > qemu-char.c | 39 ++++++++++++++++++++------------------- > 1 file changed, 20 insertions(+), 19 deletions(-) > Thanks, queued for the next pull request (next week). Paolo