qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] nbd: Fix poor debug message
Date: Fri, 1 Apr 2016 12:47:04 +0200	[thread overview]
Message-ID: <56FE51A8.8010409@redhat.com> (raw)
In-Reply-To: <1459459222-8637-3-git-send-email-eblake@redhat.com>



On 31/03/2016 23:20, Eric Blake wrote:
> The client sends messages to the server, not itself.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  nbd/client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nbd/client.c b/nbd/client.c
> index 5af9f26..d95ad7a 100644
> --- a/nbd/client.c
> +++ b/nbd/client.c
> @@ -635,7 +635,7 @@ ssize_t nbd_send_request(QIOChannel *ioc, struct nbd_request *request)
>      cpu_to_be64w((uint64_t *)(buf + 16), request->from);
>      cpu_to_be32w((uint32_t *)(buf + 24), request->len);
> 
> -    TRACE("Sending request to client: "
> +    TRACE("Sending request to server: "
>            "{ .from = %" PRIu64", .len = %u, .handle = %" PRIu64
>            ", .flags=%x, .type=%i}",
>            request->from, request->len, request->handle, request->flags,
> 

(Rebased and) queued for 2.6.

Paolo

  reply	other threads:[~2016-04-01 10:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 21:20 [Qemu-devel] [PATCH 0/3] NBD: flag handling cleanup Eric Blake
2016-03-31 21:20 ` [Qemu-devel] [PATCH 1/3] nbd: Treat flags vs. command type as separate fields Eric Blake
2016-03-31 21:20 ` [Qemu-devel] [PATCH 2/3] nbd: Fix poor debug message Eric Blake
2016-04-01 10:47   ` Paolo Bonzini [this message]
2016-03-31 21:20 ` [Qemu-devel] [PATCH 3/3] nbd: Reject unknown request flags Eric Blake
2016-04-01 10:47   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FE51A8.8010409@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).