From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwbf-0008VV-LV for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:47:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alwbc-0002gB-G8 for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:47:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwbc-0002g5-Ax for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:47:08 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8D64710A3 for ; Fri, 1 Apr 2016 10:47:07 +0000 (UTC) References: <1459459222-8637-1-git-send-email-eblake@redhat.com> <1459459222-8637-3-git-send-email-eblake@redhat.com> From: Paolo Bonzini Message-ID: <56FE51A8.8010409@redhat.com> Date: Fri, 1 Apr 2016 12:47:04 +0200 MIME-Version: 1.0 In-Reply-To: <1459459222-8637-3-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] nbd: Fix poor debug message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org On 31/03/2016 23:20, Eric Blake wrote: > The client sends messages to the server, not itself. > > Signed-off-by: Eric Blake > --- > nbd/client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/nbd/client.c b/nbd/client.c > index 5af9f26..d95ad7a 100644 > --- a/nbd/client.c > +++ b/nbd/client.c > @@ -635,7 +635,7 @@ ssize_t nbd_send_request(QIOChannel *ioc, struct nbd_request *request) > cpu_to_be64w((uint64_t *)(buf + 16), request->from); > cpu_to_be32w((uint32_t *)(buf + 24), request->len); > > - TRACE("Sending request to client: " > + TRACE("Sending request to server: " > "{ .from = %" PRIu64", .len = %u, .handle = %" PRIu64 > ", .flags=%x, .type=%i}", > request->from, request->len, request->handle, request->flags, > (Rebased and) queued for 2.6. Paolo