From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwc8-0000xb-7E for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:47:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alwc7-0002pq-Bk for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:47:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwc7-0002pi-5r for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:47:39 -0400 References: <1459507677-16662-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Paolo Bonzini Message-ID: <56FE51C7.9090906@redhat.com> Date: Fri, 1 Apr 2016 12:47:35 +0200 MIME-Version: 1.0 In-Reply-To: <1459507677-16662-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] doc/memory: update MMIO section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 01/04/2016 12:47, Cao jin wrote: > There is no memory_region_io(). And remove a stray '-'. > > Signed-off-by: Cao jin > --- > docs/memory.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/memory.txt b/docs/memory.txt > index 97134e1..fddc0d9 100644 > --- a/docs/memory.txt > +++ b/docs/memory.txt > @@ -37,7 +37,7 @@ MemoryRegion): > > - MMIO: a range of guest memory that is implemented by host callbacks; > each read or write causes a callback to be called on the host. > - You initialize these with memory_region_io(), passing it a MemoryRegionOps > + You initialize these with memory_region_init_io(), passing it a MemoryRegionOps > structure describing the callbacks. > > - ROM: a ROM memory region works like RAM for reads (directly accessing > @@ -186,7 +186,7 @@ of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at > offset 0x2000. As a diagram: > > 0 1000 2000 3000 4000 5000 6000 7000 8000 > - |------|------|------|------|------|------|------|-------| > + |------|------|------|------|------|------|------|------| > A: [ ] > C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC] > B: [ ] > Queued for 2.6, thanks. Paolo