From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alz93-0003Uw-D8 for qemu-devel@nongnu.org; Fri, 01 Apr 2016 09:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alz90-0004J9-7y for qemu-devel@nongnu.org; Fri, 01 Apr 2016 09:29:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alz90-0004Iy-3D for qemu-devel@nongnu.org; Fri, 01 Apr 2016 09:29:46 -0400 References: <1459507590-1191-1-git-send-email-alex@alex.org.uk> <1459507590-1191-2-git-send-email-alex@alex.org.uk> From: Eric Blake Message-ID: <56FE77C9.7060303@redhat.com> Date: Fri, 1 Apr 2016 07:29:45 -0600 MIME-Version: 1.0 In-Reply-To: <1459507590-1191-2-git-send-email-alex@alex.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qdfsqcflVKgKFTwXsFTwXdjUQFEaRLSKW" Subject: Re: [Qemu-devel] [PATCHv2 2/2] Correct definition of NBD_CMD_FLAG_FUA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh , Wouter Verhelst Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qdfsqcflVKgKFTwXsFTwXdjUQFEaRLSKW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/01/2016 04:46 AM, Alex Bligh wrote: > NBD_CMD_FLAG_FUA is defined as 1<<0 in the documentation, but > 1<<16 in nbd.h. >=20 > The code currently treats the command as a 32 bit quantity > and masks this off. This is confusing. Until such time as the > code is fixed up, make it obvious this isn't really bit 16. >=20 > Signed-off-by: Alex Bligh > --- > nbd.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qdfsqcflVKgKFTwXsFTwXdjUQFEaRLSKW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW/nfJAAoJEKeha0olJ0NqpNEH/1In1Es6kszcx1Tw2ngBWVlg 6TT3hkRK7893ufAQEVDrtN13xzKMzvOPjfCEFIlRcPbX+iZ49WwI5efW+1anx9oU wMEoNaY4/2yACmi8sqG0liC52iFOj4d9JfH4oNcZzPnH0/xVJ0BIbuQ+/4yLXHte P5Sp9nVlHlwlsT0+gSylDM7i2MZ5vtd1K+CbdsFcO8i6EXgOR2rqmalgl5Z/9Ldk UBLRqaAO6dY32ESUo4LyG4RvkIQTnm76o/gy6YGesS55p+06CpHOIv1DqvH/wHSH y5qat87bJbLIA7NF7HOhDgRXuFvm7kSCbxwFs+Qix2rdtgb48SRIXs5mZIZGb48= =ayq4 -----END PGP SIGNATURE----- --qdfsqcflVKgKFTwXsFTwXdjUQFEaRLSKW--