[Qemu-devel] [PATCH] doc/proto.md: Clients MUST not set unknown client flags

[Qemu-devel] [PATCH] doc/proto.md: Clients MUST not set unknown client flags

[Alex Bligh]

Clients MUST NOT set unknown client flags. Currently this is
permitted (but 'SHOULD NOT' be done), with the result that the
server MUST drop the connection if it happens. This in effect
gives the client an inappropriate way to close the connection.

Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
 doc/proto.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/proto.md b/doc/proto.md
index 8c83382..6a7ebda 100644
--- a/doc/proto.md
+++ b/doc/proto.md
@@ -308,7 +308,7 @@ receiving the handshake flags from the server.
   set `NBD_FLAG_NO_ZEROES`. If set, the server MUST NOT send the 124
   bytes of zeroes at the end of the negotiation.
 
-Clients SHOULD NOT set any other flags; the server MUST drop the
+Clients MUST NOT set any other flags; the server MUST drop the
 connection if the client sets an unknown flag, or a flag that does
 not match something advertised by the server.
 
-- 
1.9.1

Re: [Qemu-devel] [PATCH] doc/proto.md: Clients MUST not set unknown client flags

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

On 04/01/2016 03:58 AM, Alex Bligh wrote:
> Clients MUST NOT set unknown client flags. Currently this is
> permitted (but 'SHOULD NOT' be done), with the result that the
> server MUST drop the connection if it happens. This in effect
> gives the client an inappropriate way to close the connection.
> 
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
>  doc/proto.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]