From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alzeh-0005K0-W0 for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:02:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alzed-0003fY-Qr for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:02:31 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:48648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alzed-0003f9-Ho for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:02:27 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Apr 2016 15:02:24 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id D2CD81B080FA for ; Fri, 1 Apr 2016 15:02:56 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u31E2KoZ6750476 for ; Fri, 1 Apr 2016 14:02:20 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u31E2JU7026184 for ; Fri, 1 Apr 2016 08:02:19 -0600 References: <1459516794-23629-1-git-send-email-pbonzini@redhat.com> From: Christian Borntraeger Message-ID: <56FE7F6A.1020501@de.ibm.com> Date: Fri, 1 Apr 2016 16:02:18 +0200 MIME-Version: 1.0 In-Reply-To: <1459516794-23629-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/9] virtio: aio handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, tubo@linux.vnet.ibm.com, famz@redhat.com, stefanha@redhat.com, mst@redhat.com On 04/01/2016 03:19 PM, Paolo Bonzini wrote: > This version fixes some commit messages, is based on qemu.git master > and adds Cornelia's Reviewed-by tags. There are no code changes apart > from context. > > Michael S. Tsirkin (2): > virtio: add aio handler > virtio-blk: use aio handler for data plane > > Paolo Bonzini (7): > virtio-dataplane: pass assign=true to > virtio_queue_aio_set_host_notifier_handler > virtio: make virtio_queue_notify_vq static > virtio-blk: fix disabled mode > virtio-scsi: fix disabled mode > virtio-scsi: use aio handler for data plane > virtio: merge virtio_queue_aio_set_host_notifier_handler with > virtio_queue_set_aio > virtio: remove starting/stopping checks > > hw/block/dataplane/virtio-blk.c | 35 +++++++++++---------- > hw/block/virtio-blk.c | 29 ++++++++++------- > hw/scsi/virtio-scsi-dataplane.c | 56 +++++++++++++++++++++++---------- > hw/scsi/virtio-scsi.c | 69 +++++++++++++++++++++++++++-------------- > hw/virtio/virtio.c | 37 ++++++++++++++++------ > include/hw/virtio/virtio-blk.h | 3 ++ > include/hw/virtio/virtio-scsi.h | 9 ++---- > include/hw/virtio/virtio.h | 4 +-- > 8 files changed, 158 insertions(+), 84 deletions(-) > 2.6-rc0 + this patch gives several occurences of segmentation fault when starting several guests with a reboot loop, e.g. something like using 0 as a pointer for a pthread_mutex. Thread 1 (Thread 0x3ff7b1ff910 (LWP 24233)): #0 0x000003ff7d18a178 in pthread_mutex_lock () at /lib64/libpthread.so.0 #1 0x0000000080250572 in qemu_mutex_lock (mutex=mutex@entry=0xf0) at /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:64 #2 0x00000000801b3e14 in aio_bh_new (ctx=0x0, cb=cb@entry=0x801ef148 , opaque=opaque@entry=0x3ff74000a50) at /home/cborntra/REPOS/qemu/async.c:55 #3 0x00000000801f0bf0 in blk_aio_prwv (blk=0x808ee1f0, offset=4096, qiov=0x3ff740009b8, co_entry=co_entry@entry=0x801efef8 , flags=flags@entry=(unknown: 0), cb=0x8007fb50 , opaque=0x3ff74000960) at /home/cborntra/REPOS/qemu/block/block-backend.c:904 #4 0x00000000801f0cc8 in blk_aio_readv (blk=, sector_num=, iov=, nb_sectors=, cb=, opaque=0x3ff74000960) at /home/cborntra/REPOS/qemu/block/block-backend.c:997 #5 0x000000008008062e in virtio_blk_submit_multireq (niov=, num_reqs=, start=, mrb=, blk=) at /home/cborntra/REPOS/qemu/hw/block/virtio-blk.c:361 ---Type to continue, or q to quit--- #6 0x000000008008062e in virtio_blk_submit_multireq (blk=, mrb=mrb@entry=0x3ff7b1fe780) at /home/cborntra/REPOS/qemu/hw/block/virtio-blk.c:391 #7 0x00000000800811d4 in virtio_blk_handle_vq (s=0x8090c608, vq=) at /home/cborntra/REPOS/qemu/hw/block/virtio-blk.c:593 #8 0x000000008009c9ee in virtio_queue_host_notifier_aio_read (vq=0x80d361d0) at /home/cborntra/REPOS/qemu/hw/virtio/virtio.c:1098 #9 0x000000008009c9ee in virtio_queue_host_notifier_aio_read (n=0x80d36230) at /home/cborntra/REPOS/qemu/hw/virtio/virtio.c:1799 #10 0x00000000801bece6 in aio_dispatch (ctx=ctx@entry=0x808c35d0) at /home/cborntra/REPOS/qemu/aio-posix.c:327 #11 0x00000000801bef44 in aio_poll (ctx=0x808c35d0, blocking=) at /home/cborntra/REPOS/qemu/aio-posix.c:475 #12 0x00000000800e2db8 in iothread_run (opaque=0x808c3090) at /home/cborntra/REPOS/qemu/iothread.c:46 #13 0x000003ff7d187c2c in start_thread () at /lib64/libpthread.so.0 #14 0x000003ff7d08ec9a in thread_start () at /lib64/libc.so.6