From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1am5wI-0007tX-EB
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 16:45:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1am5wD-0001sB-Vq
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 16:45:06 -0400
Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:33595)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1am5wD-0001re-SG
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 16:45:01 -0400
Received: by mail-qg0-x22d.google.com with SMTP id j35so106382417qge.0
	for <qemu-devel@nongnu.org>; Fri, 01 Apr 2016 13:45:01 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1459522179-6584-1-git-send-email-james.hogan@imgtec.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56FEDDC9.7080009@twiddle.net>
Date: Fri, 1 Apr 2016 13:44:57 -0700
MIME-Version: 1.0
In-Reply-To: <1459522179-6584-1-git-send-email-james.hogan@imgtec.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tcg/mips: Fix type of
	tcg_target_reg_alloc_order[]
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>

On 04/01/2016 07:49 AM, James Hogan wrote:
> The MIPS TCG backend is the only one to have
> tcg_target_reg_alloc_order[] elements of type TCGReg rather than int.
> This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base
> temporaries in a different order") breaking the build on MIPS since the
> type differed from indirect_reg_alloc_order[]:
>
> tcg/tcg.c:1725:44: error: pointer type mismatch in conditional expression [-Werror]
>       order = rev ? indirect_reg_alloc_order : tcg_target_reg_alloc_order;
>                                              ^
>
> Make it an array of ints to fix the build and match other architectures.
>
> Fixes: 91478cefaaf2 ("tcg: Allocate indirect_base temporaries in a different order")
> Signed-off-by: James Hogan<james.hogan@imgtec.com>
> Cc: Aurelien Jarno<aurelien@aurel32.net>
> Cc: Richard Henderson<rth@twiddle.net>
> ---
>   tcg/mips/tcg-target.inc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>

Sorry, I've had the same fix queued for some time, but have
failed to include it in a tcg pull.  I'll rectify that soon.


r~