qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Daniel P Berrange <berrange@redhat.com>
Subject: Re: [PATCH] .gitlab-ci.d/base: Mark jobs as interruptible by default
Date: Fri, 24 Feb 2023 07:22:54 +0100	[thread overview]
Message-ID: <56bf3f6b-92bd-0c89-b17b-1056ba02c4df@redhat.com> (raw)
In-Reply-To: <584c71cb-02e1-9386-44d7-ca2ce1c3253e@linaro.org>

On 23/02/2023 21.23, Philippe Mathieu-Daudé wrote:
> On 23/2/23 20:13, Thomas Huth wrote:
>> When handling pull requests in the staging branch, it often happens
>> that one of the job fails due to a problem, so that the pull request
>> can't be merged. Peter/Richard/Stefan then informs the sender of the
>> pull request and continues by pushing the next pending pull request
>> from another subsystem maintainer. Now the problem is that there might
>> still be lots of other running jobs in the pipeline of the first pull
>> request, eating up precious CI minutes though the pipeline is not
>> needed anymore. We can avoid this by marking the jobs as "interruptible".
>> With this setting, the jobs from previous pipelines are automatically
>> terminated when pushing a new one. If someone does not like this auto-
>> matic termination, it can still be disabled in the settings of the
>> repository. See this URL for details:
>>
>>   https://docs.gitlab.com/ee/ci/yaml/index.html#interruptible
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   .gitlab-ci.d/base.yml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
>> index 50fb59e147..0274228de8 100644
>> --- a/.gitlab-ci.d/base.yml
>> +++ b/.gitlab-ci.d/base.yml
>> @@ -11,6 +11,8 @@
>>       # and show the duration of each line.
>>       FF_SCRIPT_SECTIONS: 1
>> +  interruptible: true
> 
> It makes sense for mainstream, but seems counter-productive in forks.
> At least in my maintainer use case.
> 
> Is it possible to add a 'default' in .gitlab-ci.d/qemu-project.yml,
> so we can overwrite with a different namespace? 'interruptible' is
> listed in https://docs.gitlab.com/ee/ci/yaml/index.html#default.

As I wrote in the commit description: "If someone does not like this 
automatic termination, it can still be disabled in the settings of the 
repository."

See here for how to change the setting:

 
https://docs.gitlab.com/ee/ci/pipelines/settings.html#auto-cancel-redundant-pipelines

  Thomas




  reply	other threads:[~2023-02-24  6:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 19:13 [PATCH] .gitlab-ci.d/base: Mark jobs as interruptible by default Thomas Huth
2023-02-23 20:23 ` Philippe Mathieu-Daudé
2023-02-24  6:22   ` Thomas Huth [this message]
2023-02-24  8:01     ` Philippe Mathieu-Daudé
2023-02-24  8:03       ` Thomas Huth
2023-02-24  8:12         ` Philippe Mathieu-Daudé
2023-02-27 11:05 ` Daniel P. Berrangé
2023-02-27 11:32 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56bf3f6b-92bd-0c89-b17b-1056ba02c4df@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).