From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amlbx-0001zT-Oa for qemu-devel@nongnu.org; Sun, 03 Apr 2016 13:14:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amlbu-0004E5-JB for qemu-devel@nongnu.org; Sun, 03 Apr 2016 13:14:53 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:35517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amlbu-0004E1-Af for qemu-devel@nongnu.org; Sun, 03 Apr 2016 13:14:50 -0400 Received: by mail-lf0-x241.google.com with SMTP id c62so19226829lfc.2 for ; Sun, 03 Apr 2016 10:14:50 -0700 (PDT) Sender: Paolo Bonzini References: <1458817415-29247-1-git-send-email-pbonzini@redhat.com> <1458817415-29247-3-git-send-email-pbonzini@redhat.com> <20160403164839-mutt-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <57014F84.7070807@redhat.com> Date: Sun, 3 Apr 2016 19:14:44 +0200 MIME-Version: 1.0 In-Reply-To: <20160403164839-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] memory: hide mr->ram_addr from qemu_get_ram_ptr users List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: arei.gonglei@huawei.com, famz@redhat.com, qemu-devel@nongnu.org On 03/04/2016 15:49, Michael S. Tsirkin wrote: > > I agree but I think we need a better name for this function. > qemu_ram_offset_to_ptr? > Will also serve to make sure backporting patches across this > API change does not cause issues. Yes, this makes sense. If it were all in 2.6, there would be no released version with an absolute ram_addr_t argument *and* a RAMBlock* argument, but we will do the incompatible change in 2.7 and then it makes sense to rename it. Paolo