From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, sbruno@freebsd.org
Subject: Re: [Qemu-devel] [PATCH v1 2/2] include/qemu/atomic: add compile time asserts
Date: Mon, 4 Apr 2016 10:33:51 +0200 [thread overview]
Message-ID: <570226EF.7090707@redhat.com> (raw)
In-Reply-To: <87pou9fk2i.fsf@linaro.org>
On 01/04/2016 17:03, Alex Bennée wrote:
>
>> > To be safely portable no atomic access should be trying to do more than
>> > the natural word width of the host. The most common abuse is trying to
>> > atomically access 64 bit values on a 32 bit host.
>> >
>> > This patch adds some QEMU_BUILD_BUG_ON to the __atomic instrinsic paths
>> > to create a build failure if (sizeof(*ptr) > sizeof(void *)).
>> >
>> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> Ping Paolo. Is this worth including in a re-spin?
Yes, please.
prev parent reply other threads:[~2016-04-04 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 16:23 [Qemu-devel] [PATCH v1 0/2] Fix for FreeBSD compile on i386 Alex Bennée
2016-03-21 16:23 ` [Qemu-devel] [PATCH v1 1/2] cpus: don't use atomic_read for vm_clock_warp_start Alex Bennée
2016-03-21 16:26 ` Paolo Bonzini
2016-03-21 17:45 ` Alex Bennée
2016-03-21 16:23 ` [Qemu-devel] [PATCH v1 2/2] include/qemu/atomic: add compile time asserts Alex Bennée
2016-04-01 15:03 ` Alex Bennée
2016-04-04 8:33 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570226EF.7090707@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sbruno@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).