From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an0PI-0007Q2-2n for qemu-devel@nongnu.org; Mon, 04 Apr 2016 05:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an0PE-0002Px-7Y for qemu-devel@nongnu.org; Mon, 04 Apr 2016 05:02:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an0PE-0002Pn-2E for qemu-devel@nongnu.org; Mon, 04 Apr 2016 05:02:44 -0400 References: <1458817415-29247-1-git-send-email-pbonzini@redhat.com> <1458817415-29247-3-git-send-email-pbonzini@redhat.com> <20160403164839-mutt-send-email-mst@redhat.com> <57021FC0.6050102@redhat.com> <20160404113838-mutt-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <57022DB0.1070305@redhat.com> Date: Mon, 4 Apr 2016 11:02:40 +0200 MIME-Version: 1.0 In-Reply-To: <20160404113838-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] memory: hide mr->ram_addr from qemu_get_ram_ptr users List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: arei.gonglei@huawei.com, famz@redhat.com, qemu-devel@nongnu.org On 04/04/2016 10:38, Michael S. Tsirkin wrote: > > > I agree but I think we need a better name for this function. > > > qemu_ram_offset_to_ptr? > > > > What about qemu_map_ram_ptr? > > > > Paolo > > OK but this seems to imply there's also an unmap operation? Actually there is one, even though it's almost always a nop---it's xen_invalidate_map_cache_entry. Paolo