From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an5Ir-0003aX-Kx for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:16:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an5In-0006ss-NH for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:16:29 -0400 Received: from mail-lf0-x235.google.com ([2a00:1450:4010:c07::235]:33942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an5In-0006sa-F4 for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:16:25 -0400 Received: by mail-lf0-x235.google.com with SMTP id c62so172791302lfc.1 for ; Mon, 04 Apr 2016 07:16:24 -0700 (PDT) References: <1459435778-5526-1-git-send-email-peter.maydell@linaro.org> <1459435778-5526-3-git-send-email-peter.maydell@linaro.org> From: Sergey Fedorov Message-ID: <5702772A.1080005@linaro.org> Date: Mon, 4 Apr 2016 17:16:10 +0300 MIME-Version: 1.0 In-Reply-To: <1459435778-5526-3-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] target-arm: Remove incorrect ALIAS tags from ESR_EL2 and ESR_EL3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" On 31/03/16 17:49, Peter Maydell wrote: > The regdefs for the ESR_EL2 and ESR_EL3 system registers should not > be marked as ARM_CP_ALIAS, because these are the master copies; the > DFSR regdef in vmsa_pmsa_cp_reginfo[] is marked as an alias. > Remove the ALIAS tags so that these registers are correctly migrated. > > Signed-off-by: Peter Maydell Reviewed-by: Sergey Fedorov > --- > target-arm/helper.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index e583e6a..0e54d90 100644 > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -3509,7 +3509,6 @@ static const ARMCPRegInfo el2_cp_reginfo[] = { > .access = PL2_RW, > .fieldoffset = offsetof(CPUARMState, elr_el[2]) }, > { .name = "ESR_EL2", .state = ARM_CP_STATE_AA64, > - .type = ARM_CP_ALIAS, > .opc0 = 3, .opc1 = 4, .crn = 5, .crm = 2, .opc2 = 0, > .access = PL2_RW, .fieldoffset = offsetof(CPUARMState, cp15.esr_el[2]) }, > { .name = "FAR_EL2", .state = ARM_CP_STATE_AA64, > @@ -3759,7 +3758,6 @@ static const ARMCPRegInfo el3_cp_reginfo[] = { > .access = PL3_RW, > .fieldoffset = offsetof(CPUARMState, elr_el[3]) }, > { .name = "ESR_EL3", .state = ARM_CP_STATE_AA64, > - .type = ARM_CP_ALIAS, > .opc0 = 3, .opc1 = 6, .crn = 5, .crm = 2, .opc2 = 0, > .access = PL3_RW, .fieldoffset = offsetof(CPUARMState, cp15.esr_el[3]) }, > { .name = "FAR_EL3", .state = ARM_CP_STATE_AA64,