From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Sean Bruno" <sbruno@freebsd.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)
Date: Mon, 4 Apr 2016 16:57:52 +0200 [thread overview]
Message-ID: <570280F0.4080408@redhat.com> (raw)
In-Reply-To: <CAFEAcA8LUi6sPCbNTHZSExRK9LzYZoU-qDd6Xn33G73bSWGZLQ@mail.gmail.com>
On 04/04/2016 16:56, Peter Maydell wrote:
> On 4 April 2016 at 15:44, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 04/04/2016 16:35, Alex Bennée wrote:
>>> Only the first patch has actually changed. Instead of moving the read
>>> inside the write seqlock it is now done using the seqlock_read_*
>>> primitives.
>>>
>>> Build tested on a FreeBSB/i386 VM with these applied:
>>>
>>> https://github.com/berrange/qemu/tree/freebsd-fixes
>>>
>>> There are still a ton of unrelated warnings being kicked out of the compiler
>>> though. On the VM "make check" fails at ... but as the build was
>>> broken beforehand I can't tell if this is a regression. It passes fine
>>> on my Linux box.
>>>
>>> Alex Bennée (2):
>>> cpus: don't use atomic_read for vm_clock_warp_start
>>> include/qemu/atomic: add compile time asserts
>>>
>>> cpus.c | 10 ++++++++-
>>> include/qemu/atomic.h | 58 ++++++++++++++++++++++++++++++---------------------
>>> 2 files changed, 43 insertions(+), 25 deletions(-)
>>>
>>
>> Queued for 2.6, thanks. I will send a pull request later this week.
>
> It would be nice to fix this for rc1 (scheduled for tomorrow)...
Ok, I'll send it tomorrow then.
Paolo
next prev parent reply other threads:[~2016-04-04 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 14:35 [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?) Alex Bennée
2016-04-04 14:35 ` [Qemu-devel] [PATCH v2 1/2] cpus: don't use atomic_read for vm_clock_warp_start Alex Bennée
2016-04-04 14:35 ` [Qemu-devel] [PATCH v2 2/2] include/qemu/atomic: add compile time asserts Alex Bennée
2016-04-04 14:44 ` [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?) Paolo Bonzini
2016-04-04 14:56 ` Peter Maydell
2016-04-04 14:57 ` Paolo Bonzini [this message]
2016-04-04 18:10 ` Ed Maste
2016-04-04 19:26 ` Alex Bennée
2016-04-04 19:38 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570280F0.4080408@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sbruno@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).