From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an5x0-0003cN-MI for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:58:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an5wx-0000b7-HY for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:57:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an5wx-0000ar-D2 for qemu-devel@nongnu.org; Mon, 04 Apr 2016 10:57:55 -0400 References: <1459780549-12942-1-git-send-email-alex.bennee@linaro.org> <57027DB9.8060806@redhat.com> From: Paolo Bonzini Message-ID: <570280F0.4080408@redhat.com> Date: Mon, 4 Apr 2016 16:57:52 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Sean Bruno , =?UTF-8?Q?Alex_Benn=c3=a9e?= , QEMU Developers On 04/04/2016 16:56, Peter Maydell wrote: > On 4 April 2016 at 15:44, Paolo Bonzini wrote: >> On 04/04/2016 16:35, Alex Benn=C3=A9e wrote: >>> Only the first patch has actually changed. Instead of moving the read >>> inside the write seqlock it is now done using the seqlock_read_* >>> primitives. >>> >>> Build tested on a FreeBSB/i386 VM with these applied: >>> >>> https://github.com/berrange/qemu/tree/freebsd-fixes >>> >>> There are still a ton of unrelated warnings being kicked out of the c= ompiler >>> though. On the VM "make check" fails at ... but as the build was >>> broken beforehand I can't tell if this is a regression. It passes fin= e >>> on my Linux box. >>> >>> Alex Benn=C3=A9e (2): >>> cpus: don't use atomic_read for vm_clock_warp_start >>> include/qemu/atomic: add compile time asserts >>> >>> cpus.c | 10 ++++++++- >>> include/qemu/atomic.h | 58 ++++++++++++++++++++++++++++++-----------= ---------- >>> 2 files changed, 43 insertions(+), 25 deletions(-) >>> >> >> Queued for 2.6, thanks. I will send a pull request later this week. >=20 > It would be nice to fix this for rc1 (scheduled for tomorrow)... Ok, I'll send it tomorrow then. Paolo