From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1an8hN-0007Jp-JZ
	for qemu-devel@nongnu.org; Mon, 04 Apr 2016 13:54:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1an8hK-0004xk-DF
	for qemu-devel@nongnu.org; Mon, 04 Apr 2016 13:54:01 -0400
References: <1459767918-796-1-git-send-email-sergey.fedorov@linaro.org>
	<5702567E.6060701@weilnetz.de> <57026A7E.1000506@gmail.com>
From: Stefan Weil <sw@weilnetz.de>
Message-ID: <5702AA32.507@weilnetz.de>
Date: Mon, 4 Apr 2016 19:53:54 +0200
MIME-Version: 1.0
In-Reply-To: <57026A7E.1000506@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tci: Fix build with no '-DNDEBUG'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <serge.fdrv@gmail.com>, Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

Am 04.04.2016 um 15:22 schrieb Sergey Fedorov:
> On 04/04/16 14:56, Stefan Weil wrote:
[...]
>> There is indeed a regression in the current code. Commit
>> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement
>> which includes assert.h before NDEBUG is defined. This is wrong and
>> needs a fix. Could you please try tci.c starting like this?
>>
>> /* Defining NDEBUG disables assertions (which makes the code faster). */
>> #if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
>> # define NDEBUG
>> #endif
>>
>> #include "qemu/osdep.h"
>>
> 
> Doing so really helps. So what are the plans of how to fix the problem?
> 
> Thanks,
> Sergey


The correct fix needs a little bit more code because my first try (see
above) did not get the definition of macro CONFIG_DEBUG_TCG.

My patch was now sent to the list.

Regards,
Stefan