From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Stefan Weil <sw@weilnetz.de>,
QEMU Developer <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] tci: Fix build regression
Date: Mon, 4 Apr 2016 21:06:08 +0300 [thread overview]
Message-ID: <5702AD10.8040807@gmail.com> (raw)
In-Reply-To: <1459792209-25270-1-git-send-email-sw@weilnetz.de>
On 04/04/16 20:50, Stefan Weil wrote:
> -/* Defining NDEBUG disables assertions (which makes the code faster). */
> -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
> -# define NDEBUG
> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG defined).
> + * Without assertions, the interpreter runs much faster. */
> +#if defined(CONFIG_DEBUG_TCG)
> +# define tci_assert(cond) assert(cond)
> +#else
> +# define tci_assert(cond) (void)0
Maybe wrap the "(void)0" into parentheses?
Kind regards,
Sergey
> #endif
next prev parent reply other threads:[~2016-04-04 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 17:50 [Qemu-devel] [PATCH] tci: Fix build regression Stefan Weil
2016-04-04 18:06 ` Sergey Fedorov [this message]
2016-04-04 20:40 ` Stefan Weil
2016-04-04 21:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5702AD10.8040807@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).