From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anB6j-0006TY-KE for qemu-devel@nongnu.org; Mon, 04 Apr 2016 16:28:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anB6f-000273-Ic for qemu-devel@nongnu.org; Mon, 04 Apr 2016 16:28:21 -0400 Received: from mail-am1on0148.outbound.protection.outlook.com ([157.56.112.148]:43168 helo=emea01-am1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anB6e-000253-VS for qemu-devel@nongnu.org; Mon, 04 Apr 2016 16:28:17 -0400 References: <1459787950-15286-1-git-send-email-eblake@redhat.com> <7AD0DCB1-1868-4AAD-A03D-C976A728DD75@alex.org.uk> <5702C1AB.8020601@redhat.com> <5702C8C3.1050300@openvz.org> <5702CAEA.4060804@openvz.org> From: "Denis V. Lunev" Message-ID: <5702CE48.40302@openvz.org> Date: Mon, 4 Apr 2016 23:27:52 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: "nbd-general@lists.sourceforge.net" , Kevin Wolf , "qemu-devel@nongnu.org" , Pavel Borzenkov , "Stefan stefanha@redhat. com" , Wouter Verhelst , Paolo Bonzini On 04/04/2016 11:15 PM, Alex Bligh wrote: > On 4 Apr 2016, at 21:13, Denis V. Lunev wrote: > >> As far as I remember that text we have had a number in request >> specifying which bitmap to query and the server should reply with one >> bitmap at a time. >> >> Would this work for you? > I think that would be much better, yes, though I'd suggest the > bitmap had an ID other than a number 0..15 so other people > can use it too. > bitmap requires to negotiate granularity which is not that easy thing. If we have different granularities for 'dirty' and 'allocated' bitmaps and we can report this using this proto and can not do this cleanly with bitmap approach assuming that we will add 'NBD_STATE_DIRTY_DEALLOCATED' (0x2) state