From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40488)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1anMfn-0008KB-0C
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 04:49:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1anMfh-0002pX-RM
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 04:49:18 -0400
Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:35034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1anMfh-0002pR-Jg
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 04:49:13 -0400
Received: by mail-wm0-x241.google.com with SMTP id a140so2277285wma.2
	for <qemu-devel@nongnu.org>; Tue, 05 Apr 2016 01:49:13 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1459834253-8291-1-git-send-email-cota@braap.org>
	<1459834253-8291-2-git-send-email-cota@braap.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <57037C04.2080403@redhat.com>
Date: Tue, 5 Apr 2016 10:49:08 +0200
MIME-Version: 1.0
In-Reply-To: <1459834253-8291-2-git-send-email-cota@braap.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/10] translate-all: add missing fold of
 tb_ctx into tcg_ctx
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@listserver.greensocs.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Sergey Fedorov <serge.fdrv@gmail.com>, Richard Henderson <rth@twiddle.net>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>



On 05/04/2016 07:30, Emilio G. Cota wrote:
> Since 5e5f07e08 "TCG: Move translation block variables
> to new context inside tcg_ctx: tb_ctx" on Feb 1 2013, compilation
> of usermode + TB_DEBUG_CHECK has been broken. Fix it.
> 
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  translate-all.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/translate-all.c b/translate-all.c
> index b4df1ec..8329ea6 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -861,7 +861,8 @@ static void tb_invalidate_check(target_ulong address)
>  
>      address &= TARGET_PAGE_MASK;
>      for (i = 0; i < CODE_GEN_PHYS_HASH_SIZE; i++) {
> -        for (tb = tb_ctx.tb_phys_hash[i]; tb != NULL; tb = tb->phys_hash_next) {
> +        for (tb = tcg_ctx.tb_ctx.tb_phys_hash[i]; tb != NULL;
> +             tb = tb->phys_hash_next) {
>              if (!(address + TARGET_PAGE_SIZE <= tb->pc ||
>                    address >= tb->pc + tb->size)) {
>                  printf("ERROR invalidate: address=" TARGET_FMT_lx
> 

Thanks, queued for 2.6.

Paolo