From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51933)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1anNTV-00006a-6a
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:40:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1anNTR-00077A-VP
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:40:41 -0400
Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:34532)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1anNTR-00076L-JK
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:40:37 -0400
Received: by mail-lf0-x22c.google.com with SMTP id j11so6117864lfb.1
	for <qemu-devel@nongnu.org>; Tue, 05 Apr 2016 02:40:37 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1459783474-23588-1-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <57038810.60402@redhat.com>
Date: Tue, 5 Apr 2016 11:40:32 +0200
MIME-Version: 1.0
In-Reply-To: <1459783474-23588-1-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for
	running pbkdf test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Bruce Rogers <brogers@suse.com>



On 04/04/2016 17:24, Daniel P. Berrange wrote:
> The pbkdf test is being built based on a check for CONFIG_NETTLE.
> As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be
> instead checking CONFIG_NETTLE_KDF
> 
> Reported-by: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Reported-by: Bruce Rogers <brogers@suse.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  tests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 45b9048..651d8b2 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -92,7 +92,7 @@ check-unit-$(CONFIG_GNUTLS) += tests/test-io-channel-tls$(EXESUF)
>  check-unit-y += tests/test-io-channel-command$(EXESUF)
>  check-unit-y += tests/test-io-channel-buffer$(EXESUF)
>  check-unit-y += tests/test-base64$(EXESUF)
> -check-unit-$(if $(CONFIG_NETTLE),y,$(CONFIG_GCRYPT_KDF)) += tests/test-crypto-pbkdf$(EXESUF)
> +check-unit-$(if $(CONFIG_NETTLE_KDF),y,$(CONFIG_GCRYPT_KDF)) += tests/test-crypto-pbkdf$(EXESUF)
>  check-unit-y += tests/test-crypto-ivgen$(EXESUF)
>  check-unit-y += tests/test-crypto-afsplit$(EXESUF)
>  check-unit-y += tests/test-crypto-xts$(EXESUF)

Peter, could you please apply this directly to master for rc1?

Thanks,

Paolo