qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 10/15] doc/memory: update MMIO section
Date: Tue, 5 Apr 2016 12:19:38 +0200	[thread overview]
Message-ID: <5703913A.9020809@redhat.com> (raw)
In-Reply-To: <57038C9E.30405@cn.fujitsu.com>



On 05/04/2016 11:59, Cao jin wrote:
> Seems the patch ignore the slight modification on that memory figure,
> So commit message isn`t consistent with the patch content. And actually
> I missed to remove a space between 7000 and 8000, since I removed a "-"

Oops, I forgot to adjust the commit message---I was about to answer on
your message to explain why I removed the second hunk.  Here:


        0      1000   2000   3000   4000   5000   6000   7000    8000
        |------|------|------|------|------|------|------|-------|
  A:    [                                                       ]
  C:    [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
  B:                  [                          ]


It is correct to put 8000 right _after_ the closing bracket, because A
ends at 0x7FFF.  You can see how C and B are also aligned before the
tick at 6000.

Thanks,

Paolo

  reply	other threads:[~2016-04-05 10:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05  9:50 [Qemu-devel] [PULL 00/15] Misc changes for QEMU 2.6.0-rc1 Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 01/15] update Linux headers to 4.6 Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 02/15] target-i386/kvm: Hyper-V VMBus hypercalls blank handlers Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 03/15] memory: fix segv on qemu_ram_free(block=0x0) Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 04/15] target-i386: do not pass MSR_TSC_AUX to KVM ioctls if CPUID bit is not set Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 05/15] target-i386: assert that KVM_GET/SET_MSRS can set all requested MSRs Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 06/15] checkpatch: add target_ulong to typelist Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 07/15] util: retry getaddrinfo if getting EAI_BADFLAGS with AI_V4MAPPED Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 08/15] char: fix broken EAGAIN retry on OS-X due to errno clobbering Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 09/15] char: ensure all clients are in non-blocking mode Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 10/15] doc/memory: update MMIO section Paolo Bonzini
2016-04-05  9:59   ` Cao jin
2016-04-05 10:19     ` Paolo Bonzini [this message]
2016-04-05  9:50 ` [Qemu-devel] [PULL 11/15] nbd: don't request FUA on FLUSH Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 12/15] cpus: don't use atomic_read for vm_clock_warp_start Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 13/15] include/qemu/atomic: add compile time asserts Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 14/15] nbd: Fix poor debug message Paolo Bonzini
2016-04-05  9:50 ` [Qemu-devel] [PULL 15/15] net: fix missing include of qapi/error.h in netmap.c Paolo Bonzini
2016-04-05 10:53 ` [Qemu-devel] [PULL 00/15] Misc changes for QEMU 2.6.0-rc1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5703913A.9020809@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).