From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anO5J-0008BM-Ms for qemu-devel@nongnu.org; Tue, 05 Apr 2016 06:19:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anO5G-0001A9-IQ for qemu-devel@nongnu.org; Tue, 05 Apr 2016 06:19:45 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anO5G-0001A2-Bc for qemu-devel@nongnu.org; Tue, 05 Apr 2016 06:19:42 -0400 Received: by mail-wm0-x242.google.com with SMTP id n3so2892103wmn.1 for ; Tue, 05 Apr 2016 03:19:42 -0700 (PDT) Sender: Paolo Bonzini References: <1459849818-26649-1-git-send-email-pbonzini@redhat.com> <1459849818-26649-11-git-send-email-pbonzini@redhat.com> <57038C9E.30405@cn.fujitsu.com> From: Paolo Bonzini Message-ID: <5703913A.9020809@redhat.com> Date: Tue, 5 Apr 2016 12:19:38 +0200 MIME-Version: 1.0 In-Reply-To: <57038C9E.30405@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 10/15] doc/memory: update MMIO section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org On 05/04/2016 11:59, Cao jin wrote: > Seems the patch ignore the slight modification on that memory figure, > So commit message isn`t consistent with the patch content. And actually > I missed to remove a space between 7000 and 8000, since I removed a "-" Oops, I forgot to adjust the commit message---I was about to answer on your message to explain why I removed the second hunk. Here: 0 1000 2000 3000 4000 5000 6000 7000 8000 |------|------|------|------|------|------|------|-------| A: [ ] C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC] B: [ ] It is correct to put 8000 right _after_ the closing bracket, because A ends at 0x7FFF. You can see how C and B are also aligned before the tick at 6000. Thanks, Paolo