From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anOi3-0001kD-2p for qemu-devel@nongnu.org; Tue, 05 Apr 2016 06:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anOhz-0004mp-PG for qemu-devel@nongnu.org; Tue, 05 Apr 2016 06:59:46 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:33885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anOhz-0004ml-Eu for qemu-devel@nongnu.org; Tue, 05 Apr 2016 06:59:43 -0400 Received: by mail-wm0-x244.google.com with SMTP id n3so3170892wmn.1 for ; Tue, 05 Apr 2016 03:59:43 -0700 (PDT) Sender: Paolo Bonzini References: <1459516794-23629-1-git-send-email-pbonzini@redhat.com> <1459516794-23629-2-git-send-email-pbonzini@redhat.com> <20160405133641-mutt-send-email-mst@redhat.com> <5703969E.2050309@redhat.com> From: Paolo Bonzini Message-ID: <57039A9A.4040103@redhat.com> Date: Tue, 5 Apr 2016 12:59:38 +0200 MIME-Version: 1.0 In-Reply-To: <5703969E.2050309@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: famz@redhat.com, borntraeger@de.ibm.com, qemu-devel@nongnu.org, dgilbert@redhat.com, tubo@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com On 05/04/2016 12:42, Paolo Bonzini wrote: > I think you're right about this. > > Dataplane has an event_notifier_set; we should move it to > virtio_queue_aio_set_host_notifier_handler and add it to > virtio_queue_set_host_notifier_handler. I'll send v3 today. As discussed on IRC, even that wouldn't be safe. The good news is that this patch is not necessary, because virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, false, false) is called inside aio_context_acquire. Paolo