From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60456)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1anTFQ-0004hf-5i
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 11:50:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1anTFN-0003lS-Bv
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 11:50:32 -0400
Received: from mail-qg0-x243.google.com ([2607:f8b0:400d:c04::243]:35107)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1anTFM-0003lH-S3
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 11:50:29 -0400
Received: by mail-qg0-x243.google.com with SMTP id b32so1571374qgf.2
	for <qemu-devel@nongnu.org>; Tue, 05 Apr 2016 08:50:28 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1459834253-8291-1-git-send-email-cota@braap.org>
	<1459834253-8291-9-git-send-email-cota@braap.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <5703DEC0.80209@twiddle.net>
Date: Tue, 5 Apr 2016 08:50:24 -0700
MIME-Version: 1.0
In-Reply-To: <1459834253-8291-9-git-send-email-cota@braap.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/10] qht: QEMU's fast,
	resizable and scalable Hash Table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@greensocs.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Sergey Fedorov <serge.fdrv@gmail.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 04/04/2016 10:30 PM, Emilio G. Cota wrote:
> +struct qht_map {
> +    struct qht_bucket *buckets;
> +    uint64_t n;
> +    uint64_t n_items;
> +    uint64_t n_items_threshold;
> +    struct rcu_head rcu;
> +};

There's no point in using 64-bit data for a 32-bit host.
You should be using e.g. size_t for the counts.


r~