qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] tests: ignore test-logging
@ 2016-04-05  6:35 Changlong Xie
  2016-04-05  7:24 ` Changlong Xie
  0 siblings, 1 reply; 3+ messages in thread
From: Changlong Xie @ 2016-04-05  6:35 UTC (permalink / raw)
  To: qemu devel, qemu trivial, Paolo Bonzini, Alex Bennee, Eric Blake,
	Markus Armbruster, Kevin Wolf, Max Reitz, John Snow
  Cc: Changlong Xie

Commit 3514552e added a new test, but did not mark it for
exclusion in .gitignore.

Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
 tests/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/.gitignore b/tests/.gitignore
index b7bf13e..898a35f 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -70,5 +70,6 @@ test-xbzrle
 test-netfilter
 test-filter-mirror
 test-filter-redirector
+test-logging
 *-test
 qapi-schema/*.test.*
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: ignore test-logging
  2016-04-05  6:35 [Qemu-devel] [PATCH] tests: ignore test-logging Changlong Xie
@ 2016-04-05  7:24 ` Changlong Xie
  2016-04-05 16:44   ` Eric Blake
  0 siblings, 1 reply; 3+ messages in thread
From: Changlong Xie @ 2016-04-05  7:24 UTC (permalink / raw)
  To: qemu devel, qemu trivial, Paolo Bonzini, Alex Bennee, Eric Blake,
	Markus Armbruster, Kevin Wolf, Max Reitz, John Snow

On 04/05/2016 02:35 PM, Changlong Xie wrote:
> Commit 3514552e added a new test, but did not mark it for
> exclusion in .gitignore.
>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>   tests/.gitignore | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index b7bf13e..898a35f 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -70,5 +70,6 @@ test-xbzrle
>   test-netfilter
>   test-filter-mirror
>   test-filter-redirector
> +test-logging
>   *-test
>   qapi-schema/*.test.*
>
It seems we should keep items in order, so

 From a6d9e3aeaee66941613ebed312ee7a1b0e80bcc3 Mon Sep 17 00:00:00 2001
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Date: Thu, 31 Mar 2016 13:52:35 +0800
Subject: [PATCH] tests: ignore test-logging

Commit 3514552e added a new test, but did not mark it for
exclusion in .gitignore.

Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
  tests/.gitignore | 1 +
  1 file changed, 1 insertion(+)

diff --git a/tests/.gitignore b/tests/.gitignore
index 6479b79..a303aaa 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -39,6 +39,7 @@ test-io-channel-file.txt
  test-io-channel-socket
  test-io-channel-tls
  test-io-task
+test-logging
  test-mul64
  test-opts-visitor
  test-qapi-event.[ch]
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: ignore test-logging
  2016-04-05  7:24 ` Changlong Xie
@ 2016-04-05 16:44   ` Eric Blake
  0 siblings, 0 replies; 3+ messages in thread
From: Eric Blake @ 2016-04-05 16:44 UTC (permalink / raw)
  To: Changlong Xie, qemu devel, qemu trivial, Paolo Bonzini,
	Alex Bennee, Markus Armbruster, Kevin Wolf, Max Reitz, John Snow

[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]

On 04/05/2016 01:24 AM, Changlong Xie wrote:
> On 04/05/2016 02:35 PM, Changlong Xie wrote:
>> Commit 3514552e added a new test, but did not mark it for
>> exclusion in .gitignore.
>>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>>   tests/.gitignore | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/.gitignore b/tests/.gitignore
>> index b7bf13e..898a35f 100644
>> --- a/tests/.gitignore
>> +++ b/tests/.gitignore
>> @@ -70,5 +70,6 @@ test-xbzrle
>>   test-netfilter
>>   test-filter-mirror
>>   test-filter-redirector
>> +test-logging
>>   *-test
>>   qapi-schema/*.test.*
>>
> It seems we should keep items in order, so
> 
> From a6d9e3aeaee66941613ebed312ee7a1b0e80bcc3 Mon Sep 17 00:00:00 2001
> From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Date: Thu, 31 Mar 2016 13:52:35 +0800
> Subject: [PATCH] tests: ignore test-logging
> 
> Commit 3514552e added a new test, but did not mark it for
> exclusion in .gitignore.

May be easier to resend this as a top-level v2 (or now v3), so that it
is easier for a maintainer to pick up.  But in any case, your v2 is:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-05 16:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-05  6:35 [Qemu-devel] [PATCH] tests: ignore test-logging Changlong Xie
2016-04-05  7:24 ` Changlong Xie
2016-04-05 16:44   ` Eric Blake

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).