From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1anUdw-0000E3-3y
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 13:19:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1anUdt-0003kk-Ar
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 13:19:56 -0400
Received: from mail-qg0-x241.google.com ([2607:f8b0:400d:c04::241]:35586)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1anUdt-0003kW-2w
	for qemu-devel@nongnu.org; Tue, 05 Apr 2016 13:19:53 -0400
Received: by mail-qg0-x241.google.com with SMTP id b32so1823565qgf.2
	for <qemu-devel@nongnu.org>; Tue, 05 Apr 2016 10:19:53 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1459834253-8291-1-git-send-email-cota@braap.org>
	<1459834253-8291-8-git-send-email-cota@braap.org>
	<5703DCB7.50302@twiddle.net>
	<CABoDooO0_CBc7U7+S9M9uS_+hfDGD2q5CgzidL8XwDvZ2peDNQ@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <5703F3B4.6030108@twiddle.net>
Date: Tue, 5 Apr 2016 10:19:48 -0700
MIME-Version: 1.0
In-Reply-To: <CABoDooO0_CBc7U7+S9M9uS_+hfDGD2q5CgzidL8XwDvZ2peDNQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc,
 and flags with xxhash
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: MTTCG Devel <mttcg@greensocs.com>, Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, "Emilio G. Cota" <cota@braap.org>, Paolo Bonzini <pbonzini@redhat.com>, Sergey Fedorov <serge.fdrv@gmail.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>

On 04/05/2016 09:33 AM, Laurent Desnogues wrote:
> The 'flags' field is 64-bit.  You're thinking of cflags, I guess.

Well that's silly.  Since it's filled in via

static inline void cpu_get_tb_cpu_state(CPUMIPSState *env, target_ulong *pc,
                                        target_ulong *cs_base, int *flags)

and passed back in to generate code with

TranslationBlock *tb_gen_code(CPUState *cpu,
                              target_ulong pc, target_ulong cs_base, int flags,
                              int cflags);

So while TranslationBlock stores "uint64_t", the producer and consumer see "int".


r~