From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anZzN-0001aD-2g for qemu-devel@nongnu.org; Tue, 05 Apr 2016 19:02:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anZzM-0008Im-8t for qemu-devel@nongnu.org; Tue, 05 Apr 2016 19:02:25 -0400 Sender: Paolo Bonzini References: <1458639954-9980-1-git-send-email-weijg.fnst@cn.fujitsu.com> From: Paolo Bonzini Message-ID: <570443F6.5010603@redhat.com> Date: Wed, 6 Apr 2016 01:02:14 +0200 MIME-Version: 1.0 In-Reply-To: <1458639954-9980-1-git-send-email-weijg.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] docs: fix typo in memory.txt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Jiangang , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, mjt@tls.msk.ru, avi@redhat.com On 22/03/2016 10:45, Wei Jiangang wrote: > The scale line should align with A line's end, No, A ends at 0x7fff so the line should end just before. See what happens for B/C/D/E. However, the space between 7000 and 8000 is indede 7 characters instead of 6, so I will take your patch and also reduce the space between A's brackets. Thanks, Paolo > and correct the range of vga-window example 0xa0000-0xbffff. > Signed-off-by: Wei Jiangang > --- > docs/memory.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/memory.txt b/docs/memory.txt > index 97134e1..5a7163c 100644 > --- a/docs/memory.txt > +++ b/docs/memory.txt > @@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two > of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at > offset 0x2000. As a diagram: > > - 0 1000 2000 3000 4000 5000 6000 7000 8000 > - |------|------|------|------|------|------|------|-------| > + 0 1000 2000 3000 4000 5000 6000 7000 8000 > + |------|------|------|------|------|------|------|------| > A: [ ] > C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC] > B: [ ] > @@ -247,7 +247,7 @@ system_memory: container@0-2^48-1 > | > +---- himem: alias@0x100000000-0x11fffffff ---> #ram (0xe0000000-0xffffffff) > | > - +---- vga-window: alias@0xa0000-0xbfffff ---> #pci (0xa0000-0xbffff) > + +---- vga-window: alias@0xa0000-0xbffff ---> #pci (0xa0000-0xbffff) > | (prio 1) > | > +---- pci-hole: alias@0xe0000000-0xffffffff ---> #pci (0xe0000000-0xffffffff) >