From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: famz@redhat.com, borntraeger@de.ibm.com, mst@redhat.com,
qemu-devel@nongnu.org, tubo@linux.vnet.ibm.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/7] virtio: add aio handler
Date: Wed, 6 Apr 2016 14:09:12 +0200 [thread overview]
Message-ID: <5704FC68.6030105@redhat.com> (raw)
In-Reply-To: <20160406131117.368692e7.cornelia.huck@de.ibm.com>
On 06/04/2016 13:11, Cornelia Huck wrote:
>> > +static void virtio_queue_notify_aio_vq(VirtQueue *vq)
>> > +{
>> > + if (vq->vring.desc && vq->handle_aio_output) {
>> > + VirtIODevice *vdev = vq->vdev;
>> > +
>> > + trace_virtio_queue_notify(vdev, vq - vdev->vq, vq);
>> > + vq->handle_aio_output(vdev, vq);
>> > + }
>> > +}
>> > +
> So this avoids reentrancy, but might we miss one notify if
> ->handle_aio_output has already been unset? What am I missing?
Calling the notifier just before unset is handled by using "false,
false" when unsetting the notifier, and only setting
vq->handle_aio_output after the notifier has been unset.
Patch 7 makes things clearer.
Paolo
next prev parent reply other threads:[~2016-04-06 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 10:16 [Qemu-devel] [PATCH v3 0/7] virtio: aio handler API Paolo Bonzini
2016-04-06 10:16 ` [Qemu-devel] [PATCH 1/7] virtio: make virtio_queue_notify_vq static Paolo Bonzini
2016-04-06 10:16 ` [Qemu-devel] [PATCH 2/7] virtio-blk: fix disabled mode Paolo Bonzini
2016-04-06 10:16 ` [Qemu-devel] [PATCH 3/7] virtio-scsi: " Paolo Bonzini
2016-04-06 10:16 ` [Qemu-devel] [PATCH 4/7] virtio: add aio handler Paolo Bonzini
2016-04-06 11:11 ` Cornelia Huck
2016-04-06 12:09 ` Paolo Bonzini [this message]
2016-04-06 13:42 ` Cornelia Huck
2016-04-06 10:16 ` [Qemu-devel] [PATCH 5/7] virtio-blk: use aio handler for data plane Paolo Bonzini
2016-04-06 10:16 ` [Qemu-devel] [PATCH 6/7] virtio-scsi: " Paolo Bonzini
2016-04-06 10:16 ` [Qemu-devel] [PATCH 7/7] virtio: merge virtio_queue_aio_set_host_notifier_handler with virtio_queue_set_aio Paolo Bonzini
2016-04-06 16:38 ` [Qemu-devel] [PATCH v3 0/7] virtio: aio handler API Cornelia Huck
2016-04-07 8:23 ` Christian Borntraeger
2016-04-07 21:33 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5704FC68.6030105@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tubo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).