From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ano8h-0001L8-UN for qemu-devel@nongnu.org; Wed, 06 Apr 2016 10:09:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ano8c-0002rR-Az for qemu-devel@nongnu.org; Wed, 06 Apr 2016 10:08:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ano8c-0002rM-5P for qemu-devel@nongnu.org; Wed, 06 Apr 2016 10:08:54 -0400 References: <1459787950-15286-1-git-send-email-eblake@redhat.com> <20160404224039.GB32049@grep.be> <5702F2B5.8060206@redhat.com> <5704A55B.40804@openvz.org> From: Eric Blake Message-ID: <57051873.5010404@redhat.com> Date: Wed, 6 Apr 2016 08:08:51 -0600 MIME-Version: 1.0 In-Reply-To: <5704A55B.40804@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gX8ARwMOvqoTSF7Jr6wecifSTHJi9MF33" Subject: Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , Wouter Verhelst Cc: nbd-general@lists.sourceforge.net, Kevin Wolf , qemu-devel@nongnu.org, Pavel Borzenkov , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gX8ARwMOvqoTSF7Jr6wecifSTHJi9MF33 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/05/2016 11:57 PM, Denis V. Lunev wrote: >> Looks like there will still be some more conversation and at least a v= 3 >> needed, but I'll wait a couple days for that to happen so that more >> reviewers can chime in, without being too tired during the review >> process. >> > that looks correct to me. I agree that we should set only one flag > and reject the request with two of them. > Actually this is like "bitmap number", but we have limitation with 32 > numbers only. >=20 > We could specify that the server MUST reply with "all 1" for unknown > flag. This would provide nice forward compatibility. My v2 approach was to define the status so that "all 0" was the safe default (hence, naming the flag "NBD_STATUS_CLEAN" and set to 1 only when no longer dirty, not "NBD_STATUS_DIRTY" where 1 by default is safer)= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gX8ARwMOvqoTSF7Jr6wecifSTHJi9MF33 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXBRhzAAoJEKeha0olJ0NqBsoH/jZIugi79tve+rCza7gmw9e8 DDEktgI7G9Jyow5+chXyxwGZwPE+vontmgoX5GYUohjCB3No2X6Ecbp9yHYEhQCN pOZ8oe/O6r5Ip9UEeHSBOZTNiI2DgbkR7m6XSiqjNm2BcdbEcX4pjw5BoFalW6tx DhKhq9l2KbQAdm78WFOAxNk1qhe6BuaOqfd3Emd6dAfmcfZKjmqU4aoXxXkuyAos iDe9rEGlm/Wg+Ikd5qtzfa31gcn/yE7nHE1iJunELYAqP6vcyM9i6DHn+KZGUywY jXu8fZh78bIGT+rJlPSf6rI1sFlVumDdcW6PlxJuJOwCyZ08dsCfXV2o50lWWa8= =su3a -----END PGP SIGNATURE----- --gX8ARwMOvqoTSF7Jr6wecifSTHJi9MF33--