From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anoAs-00039f-DR for qemu-devel@nongnu.org; Wed, 06 Apr 2016 10:11:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anoAp-0003E0-7B for qemu-devel@nongnu.org; Wed, 06 Apr 2016 10:11:14 -0400 References: <1459934178-6142-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <570518F3.30307@redhat.com> Date: Wed, 6 Apr 2016 08:10:59 -0600 MIME-Version: 1.0 In-Reply-To: <1459934178-6142-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wGKI9wrckETqDQwundkrXCP1wILNXcaQJ" Subject: Re: [Qemu-devel] [PATCH] qemu-img: fix formatting of error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wGKI9wrckETqDQwundkrXCP1wILNXcaQJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/06/2016 03:16 AM, Daniel P. Berrange wrote: > The error_reportf_err() will not automatically append a > ': ' before adding its suffix, so we must include that > in the message we pass it, otherwise we get a badly > formatted message lacking whitespace: >=20 > qemu-img: Could not open 'driver=3Dnbd,host=3D127.0.0.1,port=3D6666,tls= -creds=3Dtls0'Failed to connect socket: Connection refused >=20 > Signed-off-by: Daniel P. Berrange > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/qemu-img.c b/qemu-img.c > index 06264d9..17c5cfd 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -256,7 +256,7 @@ static BlockBackend *img_open_opts(const char *opts= tr, > options =3D qemu_opts_to_qdict(opts, NULL); > blk =3D blk_new_open(NULL, NULL, options, flags, &local_err); > if (!blk) { > - error_reportf_err(local_err, "Could not open '%s'", optstr); > + error_reportf_err(local_err, "Could not open '%s': ", optstr);= > return NULL; > } > blk_set_enable_write_cache(blk, !writethrough); >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wGKI9wrckETqDQwundkrXCP1wILNXcaQJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXBRjzAAoJEKeha0olJ0NqTKQH/jzXwQ9yBPO431D0a1/ThlYd O/Y4x9wQsImdMSffO8+1t8c0A+ATYlP3nw4FgSZhrqF5wtnEHVdxtf3oAE44zqLd 8beVLOQQbw8dMciuvy3jNUcMsGqpZn+In8MSgyrEkac3YXy1bcx4qDmVq1/IRM4+ BOh+G047VK5wgOxv0lOCuiug33CmJc9m6Rlp7+CrGrAcnMaqxZdGKRe4si6rLUbj kGbMf3tIkPWFr/Y/cQRsedasNKsMFr8dwmWfUAsuY5f/4V/oxbP1QYrFVt7k/8fj T3HrQSPfrg+z+a67t9bxKwYJDpX12DKpiYQA/1AspHDNTmbTu3qRSyM22fOXOaA= =PXBK -----END PGP SIGNATURE----- --wGKI9wrckETqDQwundkrXCP1wILNXcaQJ--