From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anpnl-0001Vn-Hk for qemu-devel@nongnu.org; Wed, 06 Apr 2016 11:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anpnk-0004oR-GW for qemu-devel@nongnu.org; Wed, 06 Apr 2016 11:55:29 -0400 References: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> <1459848109-29756-4-git-send-email-silbe@linux.vnet.ibm.com> From: Max Reitz Message-ID: <57053165.2030001@redhat.com> Date: Wed, 6 Apr 2016 17:55:17 +0200 MIME-Version: 1.0 In-Reply-To: <1459848109-29756-4-git-send-email-silbe@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qn3cWKALf3e1TsL8cCPV0jhRigdGB7JI1" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Qn3cWKALf3e1TsL8cCPV0jhRigdGB7JI1 Content-Type: multipart/mixed; boundary="nxTx2fJ08Mtk7gP5twagsk3s8OA0f92XG" From: Max Reitz To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo Message-ID: <57053165.2030001@redhat.com> Subject: Re: [Qemu-block] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error References: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> <1459848109-29756-4-git-send-email-silbe@linux.vnet.ibm.com> In-Reply-To: <1459848109-29756-4-git-send-email-silbe@linux.vnet.ibm.com> --nxTx2fJ08Mtk7gP5twagsk3s8OA0f92XG Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 05.04.2016 11:21, Sascha Silbe wrote: > On error, VM.launch() cleaned up the monitor unix socket, but left the > qtest unix socket behind. This caused the remaining sub-tests to fail > with EADDRINUSE: >=20 > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +ERROR: testQuorum (__main__.TestFifoQuorumEvents) > +----------------------------------------------------------------------= > +Traceback (most recent call last): > + File "148", line 63, in setUp > + self.vm.launch() > + File "/home6/silbe/qemu/tests/qemu-iotests/iotests.py", line 247, in= launch > + self._qmp.accept() > + File "/home6/silbe/qemu/tests/qemu-iotests/../../scripts/qmp/qmp.py"= , line 141, in accept > + return self.__negotiate_capabilities() > + File "/home6/silbe/qemu/tests/qemu-iotests/../../scripts/qmp/qmp.py"= , line 57, in __negotiate_capabilities > + raise QMPConnectError > +QMPConnectError > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +ERROR: testQuorum (__main__.TestQuorumEvents) > +----------------------------------------------------------------------= > +Traceback (most recent call last): > + File "148", line 63, in setUp > + self.vm.launch() > + File "/home6/silbe/qemu/tests/qemu-iotests/iotests.py", line 244, in= launch > + self._qtest =3D qtest.QEMUQtestProtocol(self._qtest_path, server=3D= True) > + File "/home6/silbe/qemu/tests/qemu-iotests/../../scripts/qtest.py", = line 33, in __init__ > + self._sock.bind(self._address) > + File "/usr/lib64/python2.7/socket.py", line 224, in meth > + return getattr(self._sock,name)(*args) > +error: [Errno 98] Address already in use >=20 > Fix this by cleaning up both the monitor socket and the qtest socket if= f > they exist. >=20 > Signed-off-by: Sascha Silbe > Reviewed-by: Bo Tu > --- > tests/qemu-iotests/iotests.py | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) Not sure about the leading underscore (it appears to be the only such function in iotests.py besides __init__()), but I guess it's a test so it doesn't really matter anyway. Reviewed-by: Max Reitz --nxTx2fJ08Mtk7gP5twagsk3s8OA0f92XG-- --Qn3cWKALf3e1TsL8cCPV0jhRigdGB7JI1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXBTFlAAoJEDuxQgLoOKytJiYH/0ae2dQ4n5+A80ciVxnqFM58 IRFdghSjxmimlsQcllVAHnjLtufuvafQ0b0i3/he9/B6uAPpONk66z1wc0vsNLuE YQCJo7GwYLaC8qHDGrvjpYXYIWO6FoU9MHwNDsa53db22pceJTCOj8KPJzfnLMzl ueh+c4eLdSRW8YMoWLGR73X1Zoa3sHiZrQn4W6AXNpeufPx/q26w3HzDeKojD+Lf Xk1TxQqIfIXDyCTLm5ZBEnBgDQJi+ODxK5+1CPNTMMv58zC7MK4liqn4sDp/Njyx wtDNVqF45HtJG0Uy3xem7GBZtQptREZ5ols+4zZ0MsitpLdSfJp3ySFHCw9DJ/I= =S3f6 -----END PGP SIGNATURE----- --Qn3cWKALf3e1TsL8cCPV0jhRigdGB7JI1--