From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anq9z-0004JD-Mh for qemu-devel@nongnu.org; Wed, 06 Apr 2016 12:18:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anq9y-0003LE-Rr for qemu-devel@nongnu.org; Wed, 06 Apr 2016 12:18:27 -0400 References: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> <1459848109-29756-8-git-send-email-silbe@linux.vnet.ibm.com> From: Max Reitz Message-ID: <570536CB.5070504@redhat.com> Date: Wed, 6 Apr 2016 18:18:19 +0200 MIME-Version: 1.0 In-Reply-To: <1459848109-29756-8-git-send-email-silbe@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ve6XD704PxDpe6rcwt9g0HgkC8cVT1lt7" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ve6XD704PxDpe6rcwt9g0HgkC8cVT1lt7 Content-Type: multipart/mixed; boundary="7ISSV3d4ggf17u1uStjiIuVDMom1nNXRx" From: Max Reitz To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo Message-ID: <570536CB.5070504@redhat.com> Subject: Re: [Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__ References: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> <1459848109-29756-8-git-send-email-silbe@linux.vnet.ibm.com> In-Reply-To: <1459848109-29756-8-git-send-email-silbe@linux.vnet.ibm.com> --7ISSV3d4ggf17u1uStjiIuVDMom1nNXRx Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 05.04.2016 11:21, Sascha Silbe wrote: > The __all__ list contained a typo for as long as the iotests module > existed. That typo prevented "from iotests import *" (which is the > only case where iotests.__all__ is used at all) from ever working. Hahaha :D Nice one. > The names used by iotests are highly prone to name collisions, so > importing them all unconditionally is a bad idea anyway. Since __all__ > is not adding any value, let's just get rid of it. >=20 > Fixes: f345cfd0 ("qemu-iotests: add iotests Python module") > Signed-off-by: Sascha Silbe > Reviewed-by: Bo Tu > --- > tests/qemu-iotests/iotests.py | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Max Reitz --7ISSV3d4ggf17u1uStjiIuVDMom1nNXRx-- --ve6XD704PxDpe6rcwt9g0HgkC8cVT1lt7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXBTbLAAoJEDuxQgLoOKytdasIAKvCMOTRkOsDTg0NxTKC9nuT hPEe/dgc4fMyaakEjkn4i0poQoVG4qvYOoWYoBMLQv/w32/2iH0YU0pPpkrZWAYt NkFf3ovbNTtWCXVlpvCafPY2slvamuJCN1xksAuqFU33NZ+mPtjOX7GCD76aJ8iO jHCPmREMB1e927yANAqD44wnpPx49nTpvJUITT5oHnIb1/bJkqx4R2Ga2qsahLFz JppfDDyJ5yHy5kFjZgBI1gwJbkWL9eIExzKbBseYvHVlOuAKlf/usDPMyFJcgESn fhuFXNEF2bdiIejtPQP/z04WSVfK+kf0dZqZnduGoUDsbxn48g3k+zGso18Y3LQ= =egMv -----END PGP SIGNATURE----- --ve6XD704PxDpe6rcwt9g0HgkC8cVT1lt7--