Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

[Richard Henderson <rth@twiddle.net>]

On 04/07/2016 10:19 AM, Emilio G. Cota wrote:
> We are inconsistent with the type of tb->flags: usage varies loosely
> between int and uint64_t. Settle to uint32_t everywhere, which is
> superior to both: at least one target (aarch64) uses the most significant
> bit in the u32, and uint64_t is wasteful.
>
> Compile-tested for all targets.
>
> Suggested-by: Laurent Desnogues<laurent.desnogues@gmail.com>
> Suggested-by: Richard Henderson<rth@twiddle.net>
> Signed-off-by: Emilio G. Cota<cota@braap.org>
> ---
>   cpu-exec.c              |  6 +++---
>   exec.c                  |  2 +-
>   hw/i386/kvmvapic.c      |  2 +-
>   include/exec/exec-all.h |  5 +++--
>   target-alpha/cpu.h      |  2 +-
>   target-arm/cpu.h        |  2 +-
>   target-cris/cpu.h       |  2 +-
>   target-i386/cpu.h       |  2 +-
>   target-i386/translate.c |  2 +-
>   target-lm32/cpu.h       |  2 +-
>   target-m68k/cpu.h       |  2 +-
>   target-microblaze/cpu.h |  2 +-
>   target-mips/cpu.h       |  2 +-
>   target-moxie/cpu.h      |  2 +-
>   target-openrisc/cpu.h   |  2 +-
>   target-ppc/cpu.h        |  2 +-
>   target-s390x/cpu.h      |  2 +-
>   target-sh4/cpu.h        |  2 +-
>   target-sparc/cpu.h      |  2 +-
>   target-tilegx/cpu.h     |  2 +-
>   target-tricore/cpu.h    |  2 +-
>   target-unicore32/cpu.h  |  2 +-
>   target-xtensa/cpu.h     |  2 +-
>   translate-all.c         | 10 +++++-----
>   24 files changed, 32 insertions(+), 31 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~