From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEvv-000619-LP for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:45:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoEuo-0008Ic-AM for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:44:30 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:52024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEuo-0008IX-7F for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:44:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEOA-0006HE-BX for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoEO9-0008S2-AX for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:10:42 -0400 Sender: Richard Henderson References: <1460049562-23517-1-git-send-email-cota@braap.org> From: Richard Henderson Message-ID: <5706A28C.3090403@twiddle.net> Date: Thu, 7 Apr 2016 11:10:20 -0700 MIME-Version: 1.0 In-Reply-To: <1460049562-23517-1-git-send-email-cota@braap.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , Paolo Bonzini , Peter Crosthwaite , Eduardo Habkost , Michael Walle , Aurelien Jarno , Leon Alrae , Anthony Green , Jia Liu , Alexander Graf , Blue Swirl , Mark Cave-Ayland , Bastian Koppelmann , Guan Xuetao , Max Filippov , "Edgar E. Iglesias" , "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Laurent Desnogues , MTTCG Devel On 04/07/2016 10:19 AM, Emilio G. Cota wrote: > We are inconsistent with the type of tb->flags: usage varies loosely > between int and uint64_t. Settle to uint32_t everywhere, which is > superior to both: at least one target (aarch64) uses the most significant > bit in the u32, and uint64_t is wasteful. > > Compile-tested for all targets. > > Suggested-by: Laurent Desnogues > Suggested-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > cpu-exec.c | 6 +++--- > exec.c | 2 +- > hw/i386/kvmvapic.c | 2 +- > include/exec/exec-all.h | 5 +++-- > target-alpha/cpu.h | 2 +- > target-arm/cpu.h | 2 +- > target-cris/cpu.h | 2 +- > target-i386/cpu.h | 2 +- > target-i386/translate.c | 2 +- > target-lm32/cpu.h | 2 +- > target-m68k/cpu.h | 2 +- > target-microblaze/cpu.h | 2 +- > target-mips/cpu.h | 2 +- > target-moxie/cpu.h | 2 +- > target-openrisc/cpu.h | 2 +- > target-ppc/cpu.h | 2 +- > target-s390x/cpu.h | 2 +- > target-sh4/cpu.h | 2 +- > target-sparc/cpu.h | 2 +- > target-tilegx/cpu.h | 2 +- > target-tricore/cpu.h | 2 +- > target-unicore32/cpu.h | 2 +- > target-xtensa/cpu.h | 2 +- > translate-all.c | 10 +++++----- > 24 files changed, 32 insertions(+), 31 deletions(-) Reviewed-by: Richard Henderson r~