From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option
Date: Thu, 7 Apr 2016 16:14:33 -0600 [thread overview]
Message-ID: <5706DBC9.5090204@redhat.com> (raw)
In-Reply-To: <1460047845-14488-10-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On 04/07/2016 10:50 AM, Paolo Bonzini wrote:
> From: Eric Blake <eblake@redhat.com>
>
> nbd-server.c currently fails to handle unsupported options properly.
> If during option haggling the client sends an unknown request, the
> server kills the connection instead of letting the client try to
> fall back to something older. This is precisely what advertising
> NBD_FLAG_FIXED_NEWSTYLE was supposed to fix.
>
I found a couple more in our server's handling of NBD_OPT_STARTTLS; now
that you are probably going to resend the pull request, you may want to
include that one.
https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg01299.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-04-07 22:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 16:50 [Qemu-devel] [PULL 00/15] Misc patches for QEMU 2.6.0-rc2 Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 01/15] ps2kbd: default to scancode_set 2, as with KBD_CMD_RESET Paolo Bonzini
2016-04-07 18:04 ` Peter Maydell
2016-04-07 16:50 ` [Qemu-devel] [PULL 02/15] hw/timer: Revert "hpet: inverse polarity when pin above ISA_NUM_IRQS" Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 03/15] docs: fix typo in memory.txt Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 04/15] nbd: Return correct error for write to read-only export Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 05/15] nbd: Avoid bitrot in TRACE() usage Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 06/15] nbd: Improve debug traces on little-endian Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 07/15] qemu-nbd: Document -x option Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 08/15] nbd: Fix NBD unsupported options Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option Paolo Bonzini
2016-04-07 22:14 ` Eric Blake [this message]
2016-04-07 16:50 ` [Qemu-devel] [PULL 10/15] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 11/15] spapr: fix possible Negative array index read Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 12/15] hostmem-file: fix memory leak Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 13/15] translate-all: add missing fold of tb_ctx into tcg_ctx Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 14/15] tests: ignore test-logging Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 15/15] target-i386: check for PKU even for non-writable pages Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706DBC9.5090204@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).