From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoICE-0004ge-N9 for qemu-devel@nongnu.org; Thu, 07 Apr 2016 18:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoICB-0002o4-DZ for qemu-devel@nongnu.org; Thu, 07 Apr 2016 18:14:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoICB-0002nz-7p for qemu-devel@nongnu.org; Thu, 07 Apr 2016 18:14:35 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D0055C05681C for ; Thu, 7 Apr 2016 22:14:34 +0000 (UTC) References: <1460047845-14488-1-git-send-email-pbonzini@redhat.com> <1460047845-14488-10-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <5706DBC9.5090204@redhat.com> Date: Thu, 7 Apr 2016 16:14:33 -0600 MIME-Version: 1.0 In-Reply-To: <1460047845-14488-10-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rbSvQeKsWibW4gW94RusegDovTeNFVMBt" Subject: Re: [Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rbSvQeKsWibW4gW94RusegDovTeNFVMBt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/07/2016 10:50 AM, Paolo Bonzini wrote: > From: Eric Blake >=20 > nbd-server.c currently fails to handle unsupported options properly. > If during option haggling the client sends an unknown request, the > server kills the connection instead of letting the client try to > fall back to something older. This is precisely what advertising > NBD_FLAG_FIXED_NEWSTYLE was supposed to fix. >=20 I found a couple more in our server's handling of NBD_OPT_STARTTLS; now that you are probably going to resend the pull request, you may want to include that one. https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg01299.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rbSvQeKsWibW4gW94RusegDovTeNFVMBt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXBtvJAAoJEKeha0olJ0NqxQQH/A3fV1V9B0p0SksfXfXsAqoL Tj1daV1SvuAIzE22DnIF1pC74uExaYakPgATWfkdn14D4IKx8ZXT5ybGQodnM4d9 UYwMxLP5dBvJuLhif+33EMEKxhs5WsswPMdZ8eZGbyeRE7QuWwAkveSWN/CJRqy1 O1SX9BxbAuP4lER+28MBP10bx0DFS4ujtBerqTFjo36WUQgaC1Kilb2ojg3mOEa1 4w0uksqHvKZXXsSez0sFnOF28CWWLQJYFnjnvnMAHxCJRQKcyUoJryuuxvaXUy5f 0tZ2mO38erMHygEmW1vaggyerSrVpoe4l68FyDyCGRM99a0PobRxAba4YGwemiw= =mokt -----END PGP SIGNATURE----- --rbSvQeKsWibW4gW94RusegDovTeNFVMBt--