Re: [PATCH 2/2] tests/vm: Remove flex/bison packages

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 5/15/20 11:41 AM, Claudio Fontana wrote:
> On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote:
>> QEMU does use flex/bison packages.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>   tests/vm/fedora      | 1 -
>>   tests/vm/freebsd     | 1 -
>>   tests/vm/netbsd      | 1 -
>>   tests/vm/ubuntu.i386 | 2 +-
>>   4 files changed, 1 insertion(+), 4 deletions(-)
> 
> 
> Hi, does openbsd need a correction as well? Or is it needed there?

You are right. I only grepped for flex, not for bison (expecting they 
are installed altogether).

So I also missed:

- .gitlab-ci.yml
- .cirrus.yml
- tests/vm/openbsd
- scripts/coverity-scan/coverity-scan.docker

> 
> diff --git a/tests/vm/openbsd b/tests/vm/openbsd
> index 0b705f4945..13e7f9a6d5 100755
> --- a/tests/vm/openbsd
> +++ b/tests/vm/openbsd
> @@ -35,7 +35,6 @@ class OpenBSDVM(basevm.BaseVM):
>           "bash",
>           "gmake",
>           "gsed",
> -        "bison",
>   
>           # libs: usb
>           "libusb1",
> 
> Ciao,
> 
> Claudio
> 
> 
>>
>> diff --git a/tests/vm/fedora b/tests/vm/fedora
>> index bd9c6cf295..a9195670f4 100755
>> --- a/tests/vm/fedora
>> +++ b/tests/vm/fedora
>> @@ -32,7 +32,6 @@ class FedoraVM(basevm.BaseVM):
>>       pkgs = [
>>           # tools
>>           'git-core',
>> -        'flex', 'bison',
>>           'gcc', 'binutils', 'make',
>>   
>>           # perl
>> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
>> index 298967fe9c..f87db2b126 100755
>> --- a/tests/vm/freebsd
>> +++ b/tests/vm/freebsd
>> @@ -38,7 +38,6 @@ class FreeBSDVM(basevm.BaseVM):
>>           "bash",
>>           "gmake",
>>           "gsed",
>> -        "flex", "bison",
>>   
>>           # libs: crypto
>>           "gnutls",
>> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
>> index b10c9d429d..cdac502dad 100755
>> --- a/tests/vm/netbsd
>> +++ b/tests/vm/netbsd
>> @@ -36,7 +36,6 @@ class NetBSDVM(basevm.BaseVM):
>>           "bash",
>>           "gmake",
>>           "gsed",
>> -        "flex", "bison",
>>   
>>           # libs: crypto
>>           "gnutls",
>> diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
>> index 1570775335..24527cc78c 100755
>> --- a/tests/vm/ubuntu.i386
>> +++ b/tests/vm/ubuntu.i386
>> @@ -52,7 +52,7 @@ class UbuntuX86VM(basevm.BaseVM):
>>           self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list")
>>           self.ssh_root_check("apt-get update")
>>           self.ssh_root_check("apt-get build-dep -y qemu")
>> -        self.ssh_root_check("apt-get install -y libfdt-dev flex bison language-pack-en")
>> +        self.ssh_root_check("apt-get install -y libfdt-dev language-pack-en")
>>           self.ssh_root("poweroff")
>>           self.wait()
>>           os.rename(img_tmp, img)
>>
>