* [PATCH 0/2] tests: Remove unused bison/flex packages @ 2020-05-15 8:31 Philippe Mathieu-Daudé 2020-05-15 8:31 ` [PATCH 1/2] tests/docker: Remove flex/bison packages Philippe Mathieu-Daudé 2020-05-15 8:31 ` [PATCH 2/2] tests/vm: " Philippe Mathieu-Daudé 0 siblings, 2 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-05-15 8:31 UTC (permalink / raw) To: qemu-devel Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé, Claudio Fontana, David Gibson I was misguided by libdtc warnings, and thought bison/flex were required to build QEMU, so installed them in docker (and they also ended in the VM scripts). Claudio's series "libfdt: build only the strict necessary" even silents the warnings. Based-on: <20200514193811.6798-1-cfontana@suse.de> Philippe Mathieu-Daudé (2): tests/docker: Remove flex/bison packages tests/vm: Remove flex/bison packages tests/docker/dockerfiles/centos7.docker | 2 -- tests/docker/dockerfiles/centos8.docker | 2 -- tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 -- tests/docker/dockerfiles/debian10.docker | 2 -- tests/docker/dockerfiles/debian9.docker | 2 -- tests/docker/dockerfiles/fedora.docker | 2 -- tests/docker/dockerfiles/ubuntu.docker | 2 +- tests/docker/dockerfiles/ubuntu1804.docker | 2 +- tests/vm/fedora | 1 - tests/vm/freebsd | 1 - tests/vm/netbsd | 1 - tests/vm/ubuntu.i386 | 2 +- 12 files changed, 3 insertions(+), 18 deletions(-) -- 2.21.3 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] tests/docker: Remove flex/bison packages 2020-05-15 8:31 [PATCH 0/2] tests: Remove unused bison/flex packages Philippe Mathieu-Daudé @ 2020-05-15 8:31 ` Philippe Mathieu-Daudé 2020-05-15 9:02 ` Claudio Fontana 2020-05-15 8:31 ` [PATCH 2/2] tests/vm: " Philippe Mathieu-Daudé 1 sibling, 1 reply; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-05-15 8:31 UTC (permalink / raw) To: qemu-devel Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé, Claudio Fontana, David Gibson QEMU does use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/docker/dockerfiles/centos7.docker | 2 -- tests/docker/dockerfiles/centos8.docker | 2 -- tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 -- tests/docker/dockerfiles/debian10.docker | 2 -- tests/docker/dockerfiles/debian9.docker | 2 -- tests/docker/dockerfiles/fedora.docker | 2 -- tests/docker/dockerfiles/ubuntu.docker | 2 +- tests/docker/dockerfiles/ubuntu1804.docker | 2 +- 8 files changed, 2 insertions(+), 14 deletions(-) diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker index 9a2a2e515d..e197acdc3c 100644 --- a/tests/docker/dockerfiles/centos7.docker +++ b/tests/docker/dockerfiles/centos7.docker @@ -5,13 +5,11 @@ RUN yum -y update # Please keep this list sorted alphabetically ENV PACKAGES \ - bison \ bzip2 \ bzip2-devel \ ccache \ csnappy-devel \ dbus-daemon \ - flex \ gcc-c++ \ gcc \ gettext \ diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker index bfa0d33c9c..9852c5b9ee 100644 --- a/tests/docker/dockerfiles/centos8.docker +++ b/tests/docker/dockerfiles/centos8.docker @@ -3,11 +3,9 @@ FROM centos:8.1.1911 RUN dnf -y update ENV PACKAGES \ SDL-devel \ - bison \ bzip2 \ bzip2-devel \ dbus-daemon \ - flex \ gcc \ gcc-c++ \ gettext \ diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker b/tests/docker/dockerfiles/debian-xtensa-cross.docker index e6f93f65ee..beb73f46ba 100644 --- a/tests/docker/dockerfiles/debian-xtensa-cross.docker +++ b/tests/docker/dockerfiles/debian-xtensa-cross.docker @@ -11,11 +11,9 @@ RUN apt-get update && \ DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ - bison \ build-essential \ ca-certificates \ curl \ - flex \ gettext \ git \ python3-minimal diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker index 0769700a41..bcdff04ddf 100644 --- a/tests/docker/dockerfiles/debian10.docker +++ b/tests/docker/dockerfiles/debian10.docker @@ -18,12 +18,10 @@ RUN apt update && \ DEBIAN_FRONTEND=noninteractive eatmydata \ apt install -y --no-install-recommends \ bc \ - bison \ build-essential \ ca-certificates \ clang \ dbus \ - flex \ gdb-multiarch \ gettext \ git \ diff --git a/tests/docker/dockerfiles/debian9.docker b/tests/docker/dockerfiles/debian9.docker index 08cc970feb..0f0ebe530a 100644 --- a/tests/docker/dockerfiles/debian9.docker +++ b/tests/docker/dockerfiles/debian9.docker @@ -18,11 +18,9 @@ RUN apt update && \ DEBIAN_FRONTEND=noninteractive eatmydata \ apt install -y --no-install-recommends \ bc \ - bison \ build-essential \ ca-certificates \ clang \ - flex \ gdb-multiarch \ gettext \ git \ diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 179575ecaa..92b6e11c8a 100644 --- a/tests/docker/dockerfiles/fedora.docker +++ b/tests/docker/dockerfiles/fedora.docker @@ -3,7 +3,6 @@ FROM fedora:30 # Please keep this list sorted alphabetically ENV PACKAGES \ bc \ - bison \ brlapi-devel \ bzip2 \ bzip2-devel \ @@ -13,7 +12,6 @@ ENV PACKAGES \ dbus-daemon \ device-mapper-multipath-devel \ findutils \ - flex \ gcc \ gcc-c++ \ gettext \ diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker index eeb3b22bf2..90ea6311c6 100644 --- a/tests/docker/dockerfiles/ubuntu.docker +++ b/tests/docker/dockerfiles/ubuntu.docker @@ -10,7 +10,7 @@ # FROM ubuntu:19.04 -ENV PACKAGES flex bison \ +ENV PACKAGES \ ccache \ clang \ dbus \ diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker index f66b06f4cf..a10ea2850b 100644 --- a/tests/docker/dockerfiles/ubuntu1804.docker +++ b/tests/docker/dockerfiles/ubuntu1804.docker @@ -1,5 +1,5 @@ FROM ubuntu:18.04 -ENV PACKAGES flex bison \ +ENV PACKAGES \ ccache \ clang \ gcc \ -- 2.21.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tests/docker: Remove flex/bison packages 2020-05-15 8:31 ` [PATCH 1/2] tests/docker: Remove flex/bison packages Philippe Mathieu-Daudé @ 2020-05-15 9:02 ` Claudio Fontana 2020-05-15 9:21 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 8+ messages in thread From: Claudio Fontana @ 2020-05-15 9:02 UTC (permalink / raw) To: Philippe Mathieu-Daudé, qemu-devel Cc: Fam Zheng, Alex Bennée, David Gibson On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: > QEMU does use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Hi Philippe, "does" or "does not"? Ciao, Claudio > --- > tests/docker/dockerfiles/centos7.docker | 2 -- > tests/docker/dockerfiles/centos8.docker | 2 -- > tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 -- > tests/docker/dockerfiles/debian10.docker | 2 -- > tests/docker/dockerfiles/debian9.docker | 2 -- > tests/docker/dockerfiles/fedora.docker | 2 -- > tests/docker/dockerfiles/ubuntu.docker | 2 +- > tests/docker/dockerfiles/ubuntu1804.docker | 2 +- > 8 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker > index 9a2a2e515d..e197acdc3c 100644 > --- a/tests/docker/dockerfiles/centos7.docker > +++ b/tests/docker/dockerfiles/centos7.docker > @@ -5,13 +5,11 @@ RUN yum -y update > > # Please keep this list sorted alphabetically > ENV PACKAGES \ > - bison \ > bzip2 \ > bzip2-devel \ > ccache \ > csnappy-devel \ > dbus-daemon \ > - flex \ > gcc-c++ \ > gcc \ > gettext \ > diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker > index bfa0d33c9c..9852c5b9ee 100644 > --- a/tests/docker/dockerfiles/centos8.docker > +++ b/tests/docker/dockerfiles/centos8.docker > @@ -3,11 +3,9 @@ FROM centos:8.1.1911 > RUN dnf -y update > ENV PACKAGES \ > SDL-devel \ > - bison \ > bzip2 \ > bzip2-devel \ > dbus-daemon \ > - flex \ > gcc \ > gcc-c++ \ > gettext \ > diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker b/tests/docker/dockerfiles/debian-xtensa-cross.docker > index e6f93f65ee..beb73f46ba 100644 > --- a/tests/docker/dockerfiles/debian-xtensa-cross.docker > +++ b/tests/docker/dockerfiles/debian-xtensa-cross.docker > @@ -11,11 +11,9 @@ RUN apt-get update && \ > DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ > DEBIAN_FRONTEND=noninteractive eatmydata \ > apt-get install -y --no-install-recommends \ > - bison \ > build-essential \ > ca-certificates \ > curl \ > - flex \ > gettext \ > git \ > python3-minimal > diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker > index 0769700a41..bcdff04ddf 100644 > --- a/tests/docker/dockerfiles/debian10.docker > +++ b/tests/docker/dockerfiles/debian10.docker > @@ -18,12 +18,10 @@ RUN apt update && \ > DEBIAN_FRONTEND=noninteractive eatmydata \ > apt install -y --no-install-recommends \ > bc \ > - bison \ > build-essential \ > ca-certificates \ > clang \ > dbus \ > - flex \ > gdb-multiarch \ > gettext \ > git \ > diff --git a/tests/docker/dockerfiles/debian9.docker b/tests/docker/dockerfiles/debian9.docker > index 08cc970feb..0f0ebe530a 100644 > --- a/tests/docker/dockerfiles/debian9.docker > +++ b/tests/docker/dockerfiles/debian9.docker > @@ -18,11 +18,9 @@ RUN apt update && \ > DEBIAN_FRONTEND=noninteractive eatmydata \ > apt install -y --no-install-recommends \ > bc \ > - bison \ > build-essential \ > ca-certificates \ > clang \ > - flex \ > gdb-multiarch \ > gettext \ > git \ > diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker > index 179575ecaa..92b6e11c8a 100644 > --- a/tests/docker/dockerfiles/fedora.docker > +++ b/tests/docker/dockerfiles/fedora.docker > @@ -3,7 +3,6 @@ FROM fedora:30 > # Please keep this list sorted alphabetically > ENV PACKAGES \ > bc \ > - bison \ > brlapi-devel \ > bzip2 \ > bzip2-devel \ > @@ -13,7 +12,6 @@ ENV PACKAGES \ > dbus-daemon \ > device-mapper-multipath-devel \ > findutils \ > - flex \ > gcc \ > gcc-c++ \ > gettext \ > diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker > index eeb3b22bf2..90ea6311c6 100644 > --- a/tests/docker/dockerfiles/ubuntu.docker > +++ b/tests/docker/dockerfiles/ubuntu.docker > @@ -10,7 +10,7 @@ > # > > FROM ubuntu:19.04 > -ENV PACKAGES flex bison \ > +ENV PACKAGES \ > ccache \ > clang \ > dbus \ > diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker > index f66b06f4cf..a10ea2850b 100644 > --- a/tests/docker/dockerfiles/ubuntu1804.docker > +++ b/tests/docker/dockerfiles/ubuntu1804.docker > @@ -1,5 +1,5 @@ > FROM ubuntu:18.04 > -ENV PACKAGES flex bison \ > +ENV PACKAGES \ > ccache \ > clang \ > gcc \ > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tests/docker: Remove flex/bison packages 2020-05-15 9:02 ` Claudio Fontana @ 2020-05-15 9:21 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-05-15 9:21 UTC (permalink / raw) To: Claudio Fontana Cc: Fam Zheng, Alex Bennée, QEMU Developers, David Gibson On Fri, May 15, 2020 at 11:02 AM Claudio Fontana <cfontana@suse.de> wrote: > > On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: > > QEMU does use flex/bison packages. > > > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Hi Philippe, "does" or "does not"? Err... does NOT :/ > > Ciao, > > Claudio > > > --- > > tests/docker/dockerfiles/centos7.docker | 2 -- > > tests/docker/dockerfiles/centos8.docker | 2 -- > > tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 -- > > tests/docker/dockerfiles/debian10.docker | 2 -- > > tests/docker/dockerfiles/debian9.docker | 2 -- > > tests/docker/dockerfiles/fedora.docker | 2 -- > > tests/docker/dockerfiles/ubuntu.docker | 2 +- > > tests/docker/dockerfiles/ubuntu1804.docker | 2 +- > > 8 files changed, 2 insertions(+), 14 deletions(-) > > > > diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker > > index 9a2a2e515d..e197acdc3c 100644 > > --- a/tests/docker/dockerfiles/centos7.docker > > +++ b/tests/docker/dockerfiles/centos7.docker > > @@ -5,13 +5,11 @@ RUN yum -y update > > > > # Please keep this list sorted alphabetically > > ENV PACKAGES \ > > - bison \ > > bzip2 \ > > bzip2-devel \ > > ccache \ > > csnappy-devel \ > > dbus-daemon \ > > - flex \ > > gcc-c++ \ > > gcc \ > > gettext \ > > diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker > > index bfa0d33c9c..9852c5b9ee 100644 > > --- a/tests/docker/dockerfiles/centos8.docker > > +++ b/tests/docker/dockerfiles/centos8.docker > > @@ -3,11 +3,9 @@ FROM centos:8.1.1911 > > RUN dnf -y update > > ENV PACKAGES \ > > SDL-devel \ > > - bison \ > > bzip2 \ > > bzip2-devel \ > > dbus-daemon \ > > - flex \ > > gcc \ > > gcc-c++ \ > > gettext \ > > diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker b/tests/docker/dockerfiles/debian-xtensa-cross.docker > > index e6f93f65ee..beb73f46ba 100644 > > --- a/tests/docker/dockerfiles/debian-xtensa-cross.docker > > +++ b/tests/docker/dockerfiles/debian-xtensa-cross.docker > > @@ -11,11 +11,9 @@ RUN apt-get update && \ > > DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ > > DEBIAN_FRONTEND=noninteractive eatmydata \ > > apt-get install -y --no-install-recommends \ > > - bison \ > > build-essential \ > > ca-certificates \ > > curl \ > > - flex \ > > gettext \ > > git \ > > python3-minimal > > diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker > > index 0769700a41..bcdff04ddf 100644 > > --- a/tests/docker/dockerfiles/debian10.docker > > +++ b/tests/docker/dockerfiles/debian10.docker > > @@ -18,12 +18,10 @@ RUN apt update && \ > > DEBIAN_FRONTEND=noninteractive eatmydata \ > > apt install -y --no-install-recommends \ > > bc \ > > - bison \ > > build-essential \ > > ca-certificates \ > > clang \ > > dbus \ > > - flex \ > > gdb-multiarch \ > > gettext \ > > git \ > > diff --git a/tests/docker/dockerfiles/debian9.docker b/tests/docker/dockerfiles/debian9.docker > > index 08cc970feb..0f0ebe530a 100644 > > --- a/tests/docker/dockerfiles/debian9.docker > > +++ b/tests/docker/dockerfiles/debian9.docker > > @@ -18,11 +18,9 @@ RUN apt update && \ > > DEBIAN_FRONTEND=noninteractive eatmydata \ > > apt install -y --no-install-recommends \ > > bc \ > > - bison \ > > build-essential \ > > ca-certificates \ > > clang \ > > - flex \ > > gdb-multiarch \ > > gettext \ > > git \ > > diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker > > index 179575ecaa..92b6e11c8a 100644 > > --- a/tests/docker/dockerfiles/fedora.docker > > +++ b/tests/docker/dockerfiles/fedora.docker > > @@ -3,7 +3,6 @@ FROM fedora:30 > > # Please keep this list sorted alphabetically > > ENV PACKAGES \ > > bc \ > > - bison \ > > brlapi-devel \ > > bzip2 \ > > bzip2-devel \ > > @@ -13,7 +12,6 @@ ENV PACKAGES \ > > dbus-daemon \ > > device-mapper-multipath-devel \ > > findutils \ > > - flex \ > > gcc \ > > gcc-c++ \ > > gettext \ > > diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker > > index eeb3b22bf2..90ea6311c6 100644 > > --- a/tests/docker/dockerfiles/ubuntu.docker > > +++ b/tests/docker/dockerfiles/ubuntu.docker > > @@ -10,7 +10,7 @@ > > # > > > > FROM ubuntu:19.04 > > -ENV PACKAGES flex bison \ > > +ENV PACKAGES \ > > ccache \ > > clang \ > > dbus \ > > diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker > > index f66b06f4cf..a10ea2850b 100644 > > --- a/tests/docker/dockerfiles/ubuntu1804.docker > > +++ b/tests/docker/dockerfiles/ubuntu1804.docker > > @@ -1,5 +1,5 @@ > > FROM ubuntu:18.04 > > -ENV PACKAGES flex bison \ > > +ENV PACKAGES \ > > ccache \ > > clang \ > > gcc \ > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] tests/vm: Remove flex/bison packages 2020-05-15 8:31 [PATCH 0/2] tests: Remove unused bison/flex packages Philippe Mathieu-Daudé 2020-05-15 8:31 ` [PATCH 1/2] tests/docker: Remove flex/bison packages Philippe Mathieu-Daudé @ 2020-05-15 8:31 ` Philippe Mathieu-Daudé 2020-05-15 9:23 ` Philippe Mathieu-Daudé 2020-05-15 9:41 ` Claudio Fontana 1 sibling, 2 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-05-15 8:31 UTC (permalink / raw) To: qemu-devel Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé, Claudio Fontana, David Gibson QEMU does use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/vm/fedora | 1 - tests/vm/freebsd | 1 - tests/vm/netbsd | 1 - tests/vm/ubuntu.i386 | 2 +- 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/vm/fedora b/tests/vm/fedora index bd9c6cf295..a9195670f4 100755 --- a/tests/vm/fedora +++ b/tests/vm/fedora @@ -32,7 +32,6 @@ class FedoraVM(basevm.BaseVM): pkgs = [ # tools 'git-core', - 'flex', 'bison', 'gcc', 'binutils', 'make', # perl diff --git a/tests/vm/freebsd b/tests/vm/freebsd index 298967fe9c..f87db2b126 100755 --- a/tests/vm/freebsd +++ b/tests/vm/freebsd @@ -38,7 +38,6 @@ class FreeBSDVM(basevm.BaseVM): "bash", "gmake", "gsed", - "flex", "bison", # libs: crypto "gnutls", diff --git a/tests/vm/netbsd b/tests/vm/netbsd index b10c9d429d..cdac502dad 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -36,7 +36,6 @@ class NetBSDVM(basevm.BaseVM): "bash", "gmake", "gsed", - "flex", "bison", # libs: crypto "gnutls", diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 index 1570775335..24527cc78c 100755 --- a/tests/vm/ubuntu.i386 +++ b/tests/vm/ubuntu.i386 @@ -52,7 +52,7 @@ class UbuntuX86VM(basevm.BaseVM): self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list") self.ssh_root_check("apt-get update") self.ssh_root_check("apt-get build-dep -y qemu") - self.ssh_root_check("apt-get install -y libfdt-dev flex bison language-pack-en") + self.ssh_root_check("apt-get install -y libfdt-dev language-pack-en") self.ssh_root("poweroff") self.wait() os.rename(img_tmp, img) -- 2.21.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tests/vm: Remove flex/bison packages 2020-05-15 8:31 ` [PATCH 2/2] tests/vm: " Philippe Mathieu-Daudé @ 2020-05-15 9:23 ` Philippe Mathieu-Daudé 2020-05-15 9:41 ` Claudio Fontana 1 sibling, 0 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-05-15 9:23 UTC (permalink / raw) To: qemu-devel; +Cc: Fam Zheng, Alex Bennée, Claudio Fontana, David Gibson On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: > QEMU does use flex/bison packages. "... does not use ..." (Thanks Claudio). > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/vm/fedora | 1 - > tests/vm/freebsd | 1 - > tests/vm/netbsd | 1 - > tests/vm/ubuntu.i386 | 2 +- > 4 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/tests/vm/fedora b/tests/vm/fedora > index bd9c6cf295..a9195670f4 100755 > --- a/tests/vm/fedora > +++ b/tests/vm/fedora > @@ -32,7 +32,6 @@ class FedoraVM(basevm.BaseVM): > pkgs = [ > # tools > 'git-core', > - 'flex', 'bison', > 'gcc', 'binutils', 'make', > > # perl > diff --git a/tests/vm/freebsd b/tests/vm/freebsd > index 298967fe9c..f87db2b126 100755 > --- a/tests/vm/freebsd > +++ b/tests/vm/freebsd > @@ -38,7 +38,6 @@ class FreeBSDVM(basevm.BaseVM): > "bash", > "gmake", > "gsed", > - "flex", "bison", > > # libs: crypto > "gnutls", > diff --git a/tests/vm/netbsd b/tests/vm/netbsd > index b10c9d429d..cdac502dad 100755 > --- a/tests/vm/netbsd > +++ b/tests/vm/netbsd > @@ -36,7 +36,6 @@ class NetBSDVM(basevm.BaseVM): > "bash", > "gmake", > "gsed", > - "flex", "bison", > > # libs: crypto > "gnutls", > diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 > index 1570775335..24527cc78c 100755 > --- a/tests/vm/ubuntu.i386 > +++ b/tests/vm/ubuntu.i386 > @@ -52,7 +52,7 @@ class UbuntuX86VM(basevm.BaseVM): > self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list") > self.ssh_root_check("apt-get update") > self.ssh_root_check("apt-get build-dep -y qemu") > - self.ssh_root_check("apt-get install -y libfdt-dev flex bison language-pack-en") > + self.ssh_root_check("apt-get install -y libfdt-dev language-pack-en") > self.ssh_root("poweroff") > self.wait() > os.rename(img_tmp, img) > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tests/vm: Remove flex/bison packages 2020-05-15 8:31 ` [PATCH 2/2] tests/vm: " Philippe Mathieu-Daudé 2020-05-15 9:23 ` Philippe Mathieu-Daudé @ 2020-05-15 9:41 ` Claudio Fontana 2020-05-15 9:55 ` Philippe Mathieu-Daudé 1 sibling, 1 reply; 8+ messages in thread From: Claudio Fontana @ 2020-05-15 9:41 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Fam Zheng, Alex Bennée, qemu-devel, David Gibson On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: > QEMU does use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/vm/fedora | 1 - > tests/vm/freebsd | 1 - > tests/vm/netbsd | 1 - > tests/vm/ubuntu.i386 | 2 +- > 4 files changed, 1 insertion(+), 4 deletions(-) Hi, does openbsd need a correction as well? Or is it needed there? diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 0b705f4945..13e7f9a6d5 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -35,7 +35,6 @@ class OpenBSDVM(basevm.BaseVM): "bash", "gmake", "gsed", - "bison", # libs: usb "libusb1", Ciao, Claudio > > diff --git a/tests/vm/fedora b/tests/vm/fedora > index bd9c6cf295..a9195670f4 100755 > --- a/tests/vm/fedora > +++ b/tests/vm/fedora > @@ -32,7 +32,6 @@ class FedoraVM(basevm.BaseVM): > pkgs = [ > # tools > 'git-core', > - 'flex', 'bison', > 'gcc', 'binutils', 'make', > > # perl > diff --git a/tests/vm/freebsd b/tests/vm/freebsd > index 298967fe9c..f87db2b126 100755 > --- a/tests/vm/freebsd > +++ b/tests/vm/freebsd > @@ -38,7 +38,6 @@ class FreeBSDVM(basevm.BaseVM): > "bash", > "gmake", > "gsed", > - "flex", "bison", > > # libs: crypto > "gnutls", > diff --git a/tests/vm/netbsd b/tests/vm/netbsd > index b10c9d429d..cdac502dad 100755 > --- a/tests/vm/netbsd > +++ b/tests/vm/netbsd > @@ -36,7 +36,6 @@ class NetBSDVM(basevm.BaseVM): > "bash", > "gmake", > "gsed", > - "flex", "bison", > > # libs: crypto > "gnutls", > diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 > index 1570775335..24527cc78c 100755 > --- a/tests/vm/ubuntu.i386 > +++ b/tests/vm/ubuntu.i386 > @@ -52,7 +52,7 @@ class UbuntuX86VM(basevm.BaseVM): > self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list") > self.ssh_root_check("apt-get update") > self.ssh_root_check("apt-get build-dep -y qemu") > - self.ssh_root_check("apt-get install -y libfdt-dev flex bison language-pack-en") > + self.ssh_root_check("apt-get install -y libfdt-dev language-pack-en") > self.ssh_root("poweroff") > self.wait() > os.rename(img_tmp, img) > ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tests/vm: Remove flex/bison packages 2020-05-15 9:41 ` Claudio Fontana @ 2020-05-15 9:55 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 8+ messages in thread From: Philippe Mathieu-Daudé @ 2020-05-15 9:55 UTC (permalink / raw) To: Claudio Fontana; +Cc: Fam Zheng, Alex Bennée, qemu-devel, David Gibson On 5/15/20 11:41 AM, Claudio Fontana wrote: > On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: >> QEMU does use flex/bison packages. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> tests/vm/fedora | 1 - >> tests/vm/freebsd | 1 - >> tests/vm/netbsd | 1 - >> tests/vm/ubuntu.i386 | 2 +- >> 4 files changed, 1 insertion(+), 4 deletions(-) > > > Hi, does openbsd need a correction as well? Or is it needed there? You are right. I only grepped for flex, not for bison (expecting they are installed altogether). So I also missed: - .gitlab-ci.yml - .cirrus.yml - tests/vm/openbsd - scripts/coverity-scan/coverity-scan.docker > > diff --git a/tests/vm/openbsd b/tests/vm/openbsd > index 0b705f4945..13e7f9a6d5 100755 > --- a/tests/vm/openbsd > +++ b/tests/vm/openbsd > @@ -35,7 +35,6 @@ class OpenBSDVM(basevm.BaseVM): > "bash", > "gmake", > "gsed", > - "bison", > > # libs: usb > "libusb1", > > Ciao, > > Claudio > > >> >> diff --git a/tests/vm/fedora b/tests/vm/fedora >> index bd9c6cf295..a9195670f4 100755 >> --- a/tests/vm/fedora >> +++ b/tests/vm/fedora >> @@ -32,7 +32,6 @@ class FedoraVM(basevm.BaseVM): >> pkgs = [ >> # tools >> 'git-core', >> - 'flex', 'bison', >> 'gcc', 'binutils', 'make', >> >> # perl >> diff --git a/tests/vm/freebsd b/tests/vm/freebsd >> index 298967fe9c..f87db2b126 100755 >> --- a/tests/vm/freebsd >> +++ b/tests/vm/freebsd >> @@ -38,7 +38,6 @@ class FreeBSDVM(basevm.BaseVM): >> "bash", >> "gmake", >> "gsed", >> - "flex", "bison", >> >> # libs: crypto >> "gnutls", >> diff --git a/tests/vm/netbsd b/tests/vm/netbsd >> index b10c9d429d..cdac502dad 100755 >> --- a/tests/vm/netbsd >> +++ b/tests/vm/netbsd >> @@ -36,7 +36,6 @@ class NetBSDVM(basevm.BaseVM): >> "bash", >> "gmake", >> "gsed", >> - "flex", "bison", >> >> # libs: crypto >> "gnutls", >> diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 >> index 1570775335..24527cc78c 100755 >> --- a/tests/vm/ubuntu.i386 >> +++ b/tests/vm/ubuntu.i386 >> @@ -52,7 +52,7 @@ class UbuntuX86VM(basevm.BaseVM): >> self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list") >> self.ssh_root_check("apt-get update") >> self.ssh_root_check("apt-get build-dep -y qemu") >> - self.ssh_root_check("apt-get install -y libfdt-dev flex bison language-pack-en") >> + self.ssh_root_check("apt-get install -y libfdt-dev language-pack-en") >> self.ssh_root("poweroff") >> self.wait() >> os.rename(img_tmp, img) >> > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-15 9:56 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-05-15 8:31 [PATCH 0/2] tests: Remove unused bison/flex packages Philippe Mathieu-Daudé 2020-05-15 8:31 ` [PATCH 1/2] tests/docker: Remove flex/bison packages Philippe Mathieu-Daudé 2020-05-15 9:02 ` Claudio Fontana 2020-05-15 9:21 ` Philippe Mathieu-Daudé 2020-05-15 8:31 ` [PATCH 2/2] tests/vm: " Philippe Mathieu-Daudé 2020-05-15 9:23 ` Philippe Mathieu-Daudé 2020-05-15 9:41 ` Claudio Fontana 2020-05-15 9:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).