From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aobPj-0005Gu-Ki
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 14:45:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aobPg-0003AA-Bv
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 14:45:51 -0400
Received: from mail-qg0-x243.google.com ([2607:f8b0:400d:c04::243]:35680)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aobPg-0003A6-6i
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 14:45:48 -0400
Received: by mail-qg0-x243.google.com with SMTP id b32so10801401qgf.2
	for <qemu-devel@nongnu.org>; Fri, 08 Apr 2016 11:45:48 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1460050358-25025-1-git-send-email-cota@braap.org>
	<1460050358-25025-10-git-send-email-cota@braap.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <5707FC58.2080904@twiddle.net>
Date: Fri, 8 Apr 2016 11:45:44 -0700
MIME-Version: 1.0
In-Reply-To: <1460050358-25025-10-git-send-email-cota@braap.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 09/13] exec: add tb_hash_func5,
 derived from xxhash
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@greensocs.com>
Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Sergey Fedorov <serge.fdrv@gmail.com>

On 04/07/2016 10:32 AM, Emilio G. Cota wrote:
> +#include <stdint.h>

Should already be done by <qemu/osdep.h>

> +/*
> + * Note : although _rotl exists for minGW (GCC under windows), performance
> + * seems poor.
> + */
> +#if defined(_MSC_VER)
> +#  define XXH_rotl32(x, r) _rotl(x, r)
> +#else
> +#  define XXH_rotl32(x, r) ((x << r) | (x >> (32 - r)))
> +#endif

Please use rol32 from <qemu/bitops.h>

> +static inline
> +uint32_t tb_hash_func5(uint64_t a0, uint64_t b0, uint32_t e, int seed)
> +{

Is there really any point in passing in "seed" anymore?
We certainly don't want different values passed in...


r~