From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Cc: "Emilio G. Cota" <cota@braap.org>,
QEMU Developers <qemu-devel@nongnu.org>,
MTTCG Devel <mttcg@greensocs.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Sergey Fedorov <serge.fdrv@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock
Date: Fri, 8 Apr 2016 23:26:21 +0200 [thread overview]
Message-ID: <570821FD.2010107@redhat.com> (raw)
In-Reply-To: <87a8l3bxpc.fsf@linaro.org>
On 08/04/2016 23:24, Alex Bennée wrote:
> > Except that quite a lot of hosts can only (efficiently) do atomic operations on
> > a minimum of 4 byte quantities. I'd rather continue to use int here.
>
> I suspect bool == unsigned int underneath. But having true/false and 0/1 mixed up
> gets confusing even if they are equivalent.
Sometimes sizeof(bool) == 1.
Paolo
next prev parent reply other threads:[~2016-04-08 21:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 17:32 [Qemu-devel] [PATCH v2 00/10] tb hash improvements Emilio G. Cota
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 02/13] compiler.h: add QEMU_ALIGNED() to enforce struct alignment Emilio G. Cota
2016-04-08 18:26 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 03/13] seqlock: remove optional mutex Emilio G. Cota
2016-04-08 18:26 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 04/13] seqlock: rename write_lock/unlock to write_begin/end Emilio G. Cota
2016-04-08 18:27 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 05/13] include/processor.h: define cpu_relax() Emilio G. Cota
2016-04-08 18:33 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock Emilio G. Cota
2016-04-08 13:02 ` Alex Bennée
2016-04-08 18:38 ` Richard Henderson
2016-04-08 21:24 ` Alex Bennée
2016-04-08 21:26 ` Paolo Bonzini [this message]
2016-04-08 21:31 ` Richard Henderson
2016-04-08 21:35 ` Sergey Fedorov
2016-04-08 18:35 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 07/13] qemu-thread: call cpu_relax() while spinning Emilio G. Cota
2016-04-08 18:39 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 08/13] qemu-thread: optimize spin_lock for uncontended locks Emilio G. Cota
2016-04-08 18:40 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 09/13] exec: add tb_hash_func5, derived from xxhash Emilio G. Cota
2016-04-08 18:45 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 10/13] tb hash: hash phys_pc, pc, and flags with xxhash Emilio G. Cota
2016-04-08 18:48 ` Richard Henderson
2016-04-07 17:32 ` [Qemu-devel] [PATCH v2 12/13] qht: add test program Emilio G. Cota
2016-04-08 12:41 ` [Qemu-devel] [PATCH v2 00/10] tb hash improvements Alex Bennée
[not found] ` <1460050358-25025-2-git-send-email-cota@braap.org>
2016-04-08 18:25 ` [Qemu-devel] [PATCH v2 01/13] translate-all: add missing fold of tb_ctx into tcg_ctx Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570821FD.2010107@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=crosthwaite.peter@gmail.com \
--cc=mttcg@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).