* [Qemu-devel] [PATCH] smbios: fix typo
@ 2016-03-29 9:48 Cao jin
2016-03-29 9:57 ` Cao jin
0 siblings, 1 reply; 5+ messages in thread
From: Cao jin @ 2016-03-29 9:48 UTC (permalink / raw)
To: qemu-devel; +Cc: imammedo, mjt, mst
The spec says: "on paragraph (16-byte) boundaries"
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
include/hw/smbios/smbios.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h
index 76ccf70..ba36746 100644
--- a/include/hw/smbios/smbios.h
+++ b/include/hw/smbios/smbios.h
@@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType {
/* SMBIOS Entry Point
* There are two types of entry points defined in the SMBIOS specification
- * (see below). BIOS must place the entry point(s) at a 16-bit-aligned
+ * (see below). BIOS must place the entry point(s) at a 16-byte-aligned
* address between 0xf0000 and 0xfffff. Note that either entry point type
* can be used in a 64-bit target system, except that SMBIOS 2.1 entry point
* only allows the SMBIOS struct table to reside below 4GB address space.
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] smbios: fix typo
2016-03-29 9:48 [Qemu-devel] [PATCH] smbios: fix typo Cao jin
@ 2016-03-29 9:57 ` Cao jin
2016-04-09 9:13 ` Cao jin
2016-05-06 18:54 ` Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Cao jin @ 2016-03-29 9:57 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, imammedo, mjt, mst
sorry mjt, I intended to cc qemu-trivial, now I made it:)
On 03/29/2016 05:48 PM, Cao jin wrote:
> The spec says: "on paragraph (16-byte) boundaries"
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> include/hw/smbios/smbios.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h
> index 76ccf70..ba36746 100644
> --- a/include/hw/smbios/smbios.h
> +++ b/include/hw/smbios/smbios.h
> @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType {
>
> /* SMBIOS Entry Point
> * There are two types of entry points defined in the SMBIOS specification
> - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned
> + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned
> * address between 0xf0000 and 0xfffff. Note that either entry point type
> * can be used in a 64-bit target system, except that SMBIOS 2.1 entry point
> * only allows the SMBIOS struct table to reside below 4GB address space.
>
--
Yours Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] smbios: fix typo
2016-03-29 9:57 ` Cao jin
@ 2016-04-09 9:13 ` Cao jin
2016-04-15 1:41 ` Cao jin
2016-05-06 18:54 ` Michael Tokarev
1 sibling, 1 reply; 5+ messages in thread
From: Cao jin @ 2016-04-09 9:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, imammedo, mjt, mst
ping?
On 03/29/2016 05:57 PM, Cao jin wrote:
> sorry mjt, I intended to cc qemu-trivial, now I made it:)
>
> On 03/29/2016 05:48 PM, Cao jin wrote:
>> The spec says: "on paragraph (16-byte) boundaries"
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>> include/hw/smbios/smbios.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h
>> index 76ccf70..ba36746 100644
>> --- a/include/hw/smbios/smbios.h
>> +++ b/include/hw/smbios/smbios.h
>> @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType {
>>
>> /* SMBIOS Entry Point
>> * There are two types of entry points defined in the SMBIOS
>> specification
>> - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned
>> + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned
>> * address between 0xf0000 and 0xfffff. Note that either entry point
>> type
>> * can be used in a 64-bit target system, except that SMBIOS 2.1
>> entry point
>> * only allows the SMBIOS struct table to reside below 4GB address
>> space.
>>
>
--
Yours Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] smbios: fix typo
2016-04-09 9:13 ` Cao jin
@ 2016-04-15 1:41 ` Cao jin
0 siblings, 0 replies; 5+ messages in thread
From: Cao jin @ 2016-04-15 1:41 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, imammedo, mjt, mst
hi,
this is a typo patch, could I get confirmed?
For your quick reference: System Management BIOS (SMBIOS) Reference
Specification, version 3.0.0. chapter 5.2.1 & 5.2.2
On 04/09/2016 05:13 PM, Cao jin wrote:
> ping?
>
> On 03/29/2016 05:57 PM, Cao jin wrote:
>> sorry mjt, I intended to cc qemu-trivial, now I made it:)
>>
>> On 03/29/2016 05:48 PM, Cao jin wrote:
>>> The spec says: "on paragraph (16-byte) boundaries"
>>>
>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>> ---
>>> include/hw/smbios/smbios.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h
>>> index 76ccf70..ba36746 100644
>>> --- a/include/hw/smbios/smbios.h
>>> +++ b/include/hw/smbios/smbios.h
>>> @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType {
>>>
>>> /* SMBIOS Entry Point
>>> * There are two types of entry points defined in the SMBIOS
>>> specification
>>> - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned
>>> + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned
>>> * address between 0xf0000 and 0xfffff. Note that either entry point
>>> type
>>> * can be used in a 64-bit target system, except that SMBIOS 2.1
>>> entry point
>>> * only allows the SMBIOS struct table to reside below 4GB address
>>> space.
>>>
>>
>
--
Yours Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] smbios: fix typo
2016-03-29 9:57 ` Cao jin
2016-04-09 9:13 ` Cao jin
@ 2016-05-06 18:54 ` Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2016-05-06 18:54 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: qemu-trivial, imammedo, mst
29.03.2016 12:57, Cao jin wrote:
> On 03/29/2016 05:48 PM, Cao jin wrote:
>> The spec says: "on paragraph (16-byte) boundaries"
(Finally!) applied to -trivial. I'm sorry this took too long.
Thanks!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-06 18:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-29 9:48 [Qemu-devel] [PATCH] smbios: fix typo Cao jin
2016-03-29 9:57 ` Cao jin
2016-04-09 9:13 ` Cao jin
2016-04-15 1:41 ` Cao jin
2016-05-06 18:54 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).