From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Stefan Berger <stefanb@us.ibm.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] tpm: Fix write to file descriptor function
Date: Sat, 9 Apr 2016 14:08:57 -0400 [thread overview]
Message-ID: <57094539.6020203@linux.vnet.ibm.com> (raw)
In-Reply-To: <1459902110-9856-1-git-send-email-stefanb@us.ibm.com>
On 04/05/2016 08:21 PM, Stefan Berger wrote:
> Fix a bug introduced in commit 46f296c while moving send_all to the
> tpm_passthrough code. Fix the name of the variable used in the loop.
Would someone please pick up this fix?
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> ---
> hw/tpm/tpm_passthrough.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c
> index e98efb7..e88c0d2 100644
> --- a/hw/tpm/tpm_passthrough.c
> +++ b/hw/tpm/tpm_passthrough.c
> @@ -86,7 +86,7 @@ static int tpm_passthrough_unix_write(int fd, const uint8_t *buf, uint32_t len)
> int ret, remain;
>
> remain = len;
> - while (len > 0) {
> + while (remain > 0) {
> ret = write(fd, buf, remain);
> if (ret < 0) {
> if (errno != EINTR && errno != EAGAIN) {
prev parent reply other threads:[~2016-04-09 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 0:21 [Qemu-devel] [PATCH v2] tpm: Fix write to file descriptor function Stefan Berger
2016-04-09 18:08 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57094539.6020203@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanb@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).