From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap1WZ-0002bm-CJ for qemu-devel@nongnu.org; Sat, 09 Apr 2016 18:38:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ap1WY-0007tm-BK for qemu-devel@nongnu.org; Sat, 09 Apr 2016 18:38:39 -0400 References: <1460153158-21612-1-git-send-email-eblake@redhat.com> <1460153158-21612-15-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <57098467.3070702@redhat.com> Date: Sat, 9 Apr 2016 16:38:31 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ei4e9Mc1M8rLOotE1vlm2G5lDU0m1FShM" Subject: Re: [Qemu-devel] [PATCH 14/18] nbd: Implement NBD_OPT_GO on client List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: "qemu-devel@nongnu.org" , Kevin Wolf , Paolo Bonzini , "open list:Block layer core" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ei4e9Mc1M8rLOotE1vlm2G5lDU0m1FShM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/09/2016 04:47 AM, Alex Bligh wrote: >=20 > On 8 Apr 2016, at 23:05, Eric Blake wrote: >=20 >> NBD_OPT_EXPORT_NAME is lousy: it doesn't have any sane error >> reporting. Upstream NBD recently added NBD_OPT_GO as the >=20 > ... as an experimental option for now, but hopefully this > should move it out the experimental section. >=20 > Thanks for doing this one. >=20 >> improved version of the option that does what we want: it >> reports sane errors on failures (including when a server >> requires TLS but does not have NBD_OPT_GO!), and on success >> it concludes with the same data as NBD_OPT_EXPORT_NAME sends. >> >> Signed-off-by: Eric Blake >=20 > Perhaps worth adding that although all servers that support > FixedNewstyle are meant to support (i.e. error but not disconnect on) > unsupported options, perhaps some don't (in which case they > are buggy and should be fixed). But just in case someone asks > 'why is qemu no longer connecting to shonkynbd', a message in > the commit log might be useful. qemu 2.5 is one of those 'shonkynbd' servers. We just barely fixed it in commit 156f6a10 in time for 2.6, but now you've made me worry whether that will be a big enough problem to have to hack around in newer qemu clients. On the other hand, we won't merge the NBD_OPT_GO code until qemu 2.7, a few more months down the road; and we can get the fix backported to the 2.5.x stable series in the meantime. >=20 > Otherwise: >=20 > Reviewed-by: Alex Bligh >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ei4e9Mc1M8rLOotE1vlm2G5lDU0m1FShM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXCYRnAAoJEKeha0olJ0Nqb7cH/1T5NYXUQXVUPrKgYJ+i2ybh G3FMiWgh1+0ILF4xGr+In+Omr3T0xnmd1CDHhoPVdYrh1SqMUodZaqZG4aD9X6vq E5JnR6Q8mLmjijTtBmmBZg/q1l2u1tXHgY3o4Mge+rvJBs6atpaI5SEvdXvL0yp1 3LTBa8dPEZH2Hf5CKvCxCNDBWPtjhA+sKV7w7nd1FbQ8VyQJVjhSwGuSyfvuGiWN iDoG+WnNwCkOCXZzix76YsSW+El771/vT8n17IHuJ2Baep2EhuNJU6zjIlS59TUg 4B/zf0czHHsbDvOBUFlI4M6cHcPNYCiX8xM4xeN4ScGjjE3+ClzprQz+txg5sLM= =YlBZ -----END PGP SIGNATURE----- --ei4e9Mc1M8rLOotE1vlm2G5lDU0m1FShM--