From: Eric Blake <eblake@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Wouter Verhelst <w@uter.be>,
"nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [Nbd] NBD_CMD_DISC
Date: Sat, 9 Apr 2016 17:23:06 -0600 [thread overview]
Message-ID: <57098EDA.40105@redhat.com> (raw)
In-Reply-To: <56CF18E3-554D-4CF2-9DC3-6831D739A846@alex.org.uk>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
[adding qemu list and Dan into the mix]
On 04/09/2016 05:02 PM, Alex Bligh wrote:
>
> On 9 Apr 2016, at 22:12, Eric Blake <eblake@redhat.com> wrote:
>
>>> How would the client know that? I'm using Go's TLS library, and there is
>>> no way (as far as I can tell) to ensure that.
>>
>> Likewise - if it's qemu's fault for not flushing the outgoing queue,
>> then what's the right way to get that NBD_CMD_DISC flushed?
>
> You use GnuTLS. Having just (tonight) written something with
> GnuTLS, I note that
> gnutls_bye
> is not being called (in qemu) before the connection is closed
> (indeed it's not being called anywhere in qemu). Fixing that
> might help.
Dan, sounds like your QIOChannel code should start using gnutls_bye(),
as something to get into 2.6...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next parent reply other threads:[~2016-04-09 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D4F43553-381E-42EE-838E-AC8729E3D356@alex.org.uk>
[not found] ` <5705727B.1000802@redhat.com>
[not found] ` <20160409091634.GB19023@grep.be>
[not found] ` <C0E9BDD0-C8B6-412E-9835-A696A1279935@alex.org.uk>
[not found] ` <57097020.7030003@redhat.com>
[not found] ` <56CF18E3-554D-4CF2-9DC3-6831D739A846@alex.org.uk>
2016-04-09 23:23 ` Eric Blake [this message]
[not found] ` <20160409102833.GL19023@grep.be>
[not found] ` <FDFBD171-A214-4780-B3E8-7E25FB41FACB@alex.org.uk>
[not found] ` <20160409113225.GR19023@grep.be>
[not found] ` <F405A775-6A76-4776-9182-2431293A3A60@alex.org.uk>
[not found] ` <20160410082710.GA28660@grep.be>
[not found] ` <91E6DE09-E8F3-489E-B1F2-B3ECC358BB75@alex.org.uk>
[not found] ` <20160412094820.GA8122@redhat.com>
2016-04-12 10:34 ` [Qemu-devel] [Nbd] NBD_CMD_DISC Daniel P. Berrange
2016-04-12 11:14 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57098EDA.40105@redhat.com \
--to=eblake@redhat.com \
--cc=alex@alex.org.uk \
--cc=berrange@redhat.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).