From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap2Dh-0000Ft-RS for qemu-devel@nongnu.org; Sat, 09 Apr 2016 19:23:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ap2Dc-00081Y-Tx for qemu-devel@nongnu.org; Sat, 09 Apr 2016 19:23:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap2Dc-00081T-OQ for qemu-devel@nongnu.org; Sat, 09 Apr 2016 19:23:08 -0400 References: <5705727B.1000802@redhat.com> <20160409091634.GB19023@grep.be> <57097020.7030003@redhat.com> <56CF18E3-554D-4CF2-9DC3-6831D739A846@alex.org.uk> From: Eric Blake Message-ID: <57098EDA.40105@redhat.com> Date: Sat, 9 Apr 2016 17:23:06 -0600 MIME-Version: 1.0 In-Reply-To: <56CF18E3-554D-4CF2-9DC3-6831D739A846@alex.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E2F8qOHux1a9uoEVS1r121tjLl2CIm7GS" Subject: Re: [Qemu-devel] [Nbd] NBD_CMD_DISC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Wouter Verhelst , "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" , "Daniel P. Berrange" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E2F8qOHux1a9uoEVS1r121tjLl2CIm7GS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [adding qemu list and Dan into the mix] On 04/09/2016 05:02 PM, Alex Bligh wrote: >=20 > On 9 Apr 2016, at 22:12, Eric Blake wrote: >=20 >>> How would the client know that? I'm using Go's TLS library, and there= is >>> no way (as far as I can tell) to ensure that. >> >> Likewise - if it's qemu's fault for not flushing the outgoing queue, >> then what's the right way to get that NBD_CMD_DISC flushed? >=20 > You use GnuTLS. Having just (tonight) written something with > GnuTLS, I note that > gnutls_bye > is not being called (in qemu) before the connection is closed > (indeed it's not being called anywhere in qemu). Fixing that > might help. Dan, sounds like your QIOChannel code should start using gnutls_bye(), as something to get into 2.6... --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E2F8qOHux1a9uoEVS1r121tjLl2CIm7GS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXCY7aAAoJEKeha0olJ0Nqi98H/icy2oYOqSc71QloWPM/ueRA dSKpEN1kfivl7ovqo075XGtSgKMoqzZjCZ575mmZJgGEylEtf4O4nhbXrehhAb66 zSGyN8EaYvV/9gEevvnMmhL8yCUnL9DQPN3WrsD19Vdq/yDXgnDZs6lPE/AQB+LX ev4JQIIEOUSCMwYoobjM88OxyMMvUKv84ouYUNp9I6+Hmr0ekitdSRtZpD1gjIXv nLFrEWX81t3nb56U0XX9uqMRMi5iZR60EeoPC+J75oo4iu4KEimJMFwfHmV9EZ7C CMbcAlRI3SHVdLmlL2NVVAidTihVR3wS+ffun0fBWRoaTxxoSj23jr/V8Wix8i0= =RndZ -----END PGP SIGNATURE----- --E2F8qOHux1a9uoEVS1r121tjLl2CIm7GS--