From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apA1d-0004Cp-DY for qemu-devel@nongnu.org; Sun, 10 Apr 2016 03:43:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apA1Y-0001OI-Pv for qemu-devel@nongnu.org; Sun, 10 Apr 2016 03:43:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apA1Y-0001OB-Kl for qemu-devel@nongnu.org; Sun, 10 Apr 2016 03:43:12 -0400 References: <1459855602-16727-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1459855602-16727-5-git-send-email-caoj.fnst@cn.fujitsu.com> From: Marcel Apfelbaum Message-ID: <570A0404.5010708@redhat.com> Date: Sun, 10 Apr 2016 10:43:00 +0300 MIME-Version: 1.0 In-Reply-To: <1459855602-16727-5-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 4/5] mptsas: change .realize function name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: kraxel@redhat.com, jsnow@redhat.com, dmitry@daynix.com, jasowang@redhat.com, mst@redhat.com, hare@suse.de, pbonzini@redhat.com, alex.williamson@redhat.com, armbru@redhat.com On 04/05/2016 02:26 PM, Cao jin wrote: > All the other devices` .realize function name are xxx_realize, except this one > > Signed-off-by: Cao jin > CC: Paolo Bonzini > --- > hw/scsi/mptsas.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c > index 499c146..1c18c84 100644 > --- a/hw/scsi/mptsas.c > +++ b/hw/scsi/mptsas.c > @@ -1270,7 +1270,7 @@ static const struct SCSIBusInfo mptsas_scsi_info = { > .load_request = mptsas_load_request, > }; > > -static void mptsas_scsi_init(PCIDevice *dev, Error **errp) > +static void mptsas_scsi_realize(PCIDevice *dev, Error **errp) > { > DeviceState *d = DEVICE(dev); > MPTSASState *s = MPT_SAS(dev); > @@ -1413,7 +1413,7 @@ static void mptsas1068_class_init(ObjectClass *oc, void *data) > DeviceClass *dc = DEVICE_CLASS(oc); > PCIDeviceClass *pc = PCI_DEVICE_CLASS(oc); > > - pc->realize = mptsas_scsi_init; > + pc->realize = mptsas_scsi_realize; > pc->exit = mptsas_scsi_uninit; > pc->romfile = 0; > pc->vendor_id = PCI_VENDOR_ID_LSI_LOGIC; > Reviewed-by: Marcel Apfelbaum Thanks, Marcel