From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apeTs-0003fa-U1 for qemu-devel@nongnu.org; Mon, 11 Apr 2016 12:14:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apeTp-00054C-Mj for qemu-devel@nongnu.org; Mon, 11 Apr 2016 12:14:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apeTp-000548-GO for qemu-devel@nongnu.org; Mon, 11 Apr 2016 12:14:25 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 207B580E42 for ; Mon, 11 Apr 2016 16:14:25 +0000 (UTC) References: <1460387988-30034-1-git-send-email-kraxel@redhat.com> From: Eric Blake Message-ID: <570BCD5F.3020304@redhat.com> Date: Mon, 11 Apr 2016 10:14:23 -0600 MIME-Version: 1.0 In-Reply-To: <1460387988-30034-1-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rj7FXtG7cvhrEIV6AHG3w9UR8IbJBurLs" Subject: Re: [Qemu-devel] [PATCH] virtio-input: add parenthesis to const_le32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rj7FXtG7cvhrEIV6AHG3w9UR8IbJBurLs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/11/2016 09:19 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/hw/virtio/virtio-input.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) An explanation would have been helpful. > #if defined(HOST_WORDS_BIGENDIAN) > # define const_le32(_x) \ > - (((_x & 0x000000ffU) << 24) | \ The problem you are fixing is that _x needs parenthesis. > + ((((_x) & 0x000000ffU) << 24) | \ and you indeed added it, but I had to hunt because there was no explanation in the commit message. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rj7FXtG7cvhrEIV6AHG3w9UR8IbJBurLs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXC81fAAoJEKeha0olJ0NqoNQH/ioaUKIRF8ucy+slK5wxAd+7 lHLt+RqzYBbRvxBeDP7mCHuVDNwFq8GCXQVWl9rb7JxtvEEAiWACp5gE9SfWTbTN QhfOmuLcBEUgzSwpn+8LppphNwdlU/wMXecswra3w00Alb907hdBUtz/7sKHztj7 TvrukpqjH8mQwqoJjREjNWbWuhJSDScv9GCKLj/OJsPMBvtaOZSP/6ngYzF4DAmQ qF3ALCUpcJRgX+VjUJbdxodgB41mEpOh7iTJlaM7PO4bA2Uam4zdUD+SJwm1Vp1p vaJxJ0e3fSqOpht7GB1WmdVfWb9gO7WFAIR1gI3tuJUqzZkqSOvrfjhk7lpZg0E= =LOs3 -----END PGP SIGNATURE----- --rj7FXtG7cvhrEIV6AHG3w9UR8IbJBurLs--