From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48626)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1apiUN-0001aW-CS
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 16:31:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1apiUK-0000MN-7K
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 16:31:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40411)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1apiUK-0000MJ-2X
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 16:31:12 -0400
References: <1460382666-29885-1-git-send-email-anthony.perard@citrix.com>
	<alpine.DEB.2.10.1604111122470.23347@sstabellini-ThinkPad-X260>
From: John Snow <jsnow@redhat.com>
Message-ID: <570C098D.5030902@redhat.com>
Date: Mon, 11 Apr 2016 16:31:09 -0400
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1604111122470.23347@sstabellini-ThinkPad-X260>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.6] xen: Fix IDE unplug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <sstabellini@kernel.org>, Anthony PERARD <anthony.perard@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>



On 04/11/2016 02:22 PM, Stefano Stabellini wrote:
> On Mon, 11 Apr 2016, Anthony PERARD wrote:
>> After commit e5e7855 (blockdev: Separate BB name management), starting a
>> guest with PVHVM support result in this assert:
>> qemu-system-i386: block/block-backend.c:173: blk_delete: Assertion `!blk->name' failed.
>>
>> A backtrace show that a caller is pci_piix3_xen_ide_unplug().
>>
>> This patch fix it.
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> 
>>  hw/ide/piix.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ide/piix.c b/hw/ide/piix.c
>> index 0a4cbcb..6d76ce9 100644
>> --- a/hw/ide/piix.c
>> +++ b/hw/ide/piix.c
>> @@ -189,6 +189,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev)
>>                  idedev = pci_ide->bus[di->bus].slave;
>>              }
>>              idedev->conf.blk = NULL;
>> +            monitor_remove_blk(blk);
>>              blk_unref(blk);
>>          }
>>      }
>> -- 
>> Anthony PERARD
>>
> 

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js