From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq16r-000724-Sf for qemu-devel@nongnu.org; Tue, 12 Apr 2016 12:24:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aq16n-0000eQ-SX for qemu-devel@nongnu.org; Tue, 12 Apr 2016 12:24:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq16n-0000eF-KR for qemu-devel@nongnu.org; Tue, 12 Apr 2016 12:24:09 -0400 References: <1459924806-306-1-git-send-email-den@openvz.org> <570BB0B3.1090206@openvz.org> <570C1B79.2010405@redhat.com> <570C88B8.8030208@openvz.org> From: John Snow Message-ID: <570D2128.4040706@redhat.com> Date: Tue, 12 Apr 2016 12:24:08 -0400 MIME-Version: 1.0 In-Reply-To: <570C88B8.8030208@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 2.6 v4 0/3] ide: fix loss of the dma/atapi state during migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Pavel Butsykin On 04/12/2016 01:33 AM, Denis V. Lunev wrote: > On 04/12/2016 12:47 AM, John Snow wrote: >> >> On 04/11/2016 10:12 AM, Denis V. Lunev wrote: >>> On 04/06/2016 09:40 AM, Denis V. Lunev wrote: >>>> This patch set fixes bugs in the IDE DMA and the IDE ATAPI on >>>> operations to >>>> save/restore the state. >>>> >>>> From the user point of view this results in IDE timeouts in the gu= est >>>> when the user reads from the DVD like the following: >>>> >>>> [424332.169229] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 actio= n >>>> 0x6 frozen >>>> [424332.170423] sr 0:0:0:0: [sr0] CDB: >>>> [424332.171234] Read(10): 28 00 00 00 02 e4 00 00 01 00 >>>> [424332.172418] ata1.00: cmd a0/01:00:00:00:08/00:00:00:00:00/a0 tag= 0 >>>> dma 2048 in >>>> res 40/00:02:00:0c:00/00:00:00:00:00/a0 Emask 0x4 (timeou= t) >>>> [424332.174877] ata1.00: status: { DRDY } >>>> [424337.212099] ata1: link is slow to respond, please be patient >>>> (ready=3D0) >>>> [424342.220084] ata1: device not ready (errno=3D-16), forcing hardre= set >>>> [424342.222700] ata1: soft resetting link >>>> [424342.381059] ata1.00: configured for MWDMA2 >>>> [424342.383693] ata1: EH complete >>>> >>>> Another similar nasty effects are possible. >>>> >>>> Signed-off-by: Pavel Butsykin >>>> Reviewed-by: Roman Kagan >>>> Signed-off-by: Denis V. Lunev >>>> CC: John Snow >>>> >>>> Changes from v1: >>>> - added converter of IDE_DMA_* to IDE_RETRY_* (1) >>>> - fixed handling of the IDE_RETRY_HBA at the ide_restart_bh function >>>> (3) >>>> >>>> Changes from v2: >>>> - fixed enumeration value =E2=80=98IDE_DMA_ATAPI=E2=80=99 not handle= d in switch for >>>> macio.c (3) >>>> >>>> Changes from v3: >>>> - move the IDE_DMA_ATAPI setting in the cmd_packet func (3) >>>> >>>> Pavel Butsykin (3): >>>> ide: don't lose pending dma state >>>> ide: restart atapi dma by re-evaluating command packet >>>> ide: really restart pending and in-flight atapi dma >>>> >>>> hw/ide/atapi.c | 26 ++++++++++++-------------- >>>> hw/ide/core.c | 39 ++++++++++++++++----------------------- >>>> hw/ide/internal.h | 36 ++++++++++++++++++++++++++++++++++++ >>>> hw/ide/macio.c | 2 ++ >>>> hw/ide/pci.c | 4 ++++ >>>> 5 files changed, 70 insertions(+), 37 deletions(-) >>>> >>> ping >> Sorry, I don't appear to have been CC'd on the actual patch emails, so= I >> missed them. The individual patch emails also miss the "v4" tag which >> makes them hard to spot.... and it's hard to figure out what's been >> changed or not since my reviewed-by was added to all three patches, ev= en >> though I only acknowledged the first 2/3.an reaction time of about 265= millise >> > this is strange for me - you R-b: was added only to patches 1-2, here i= s > a quote >=20 > "The patch fixes the restart of both in-flight and pending ATAPI DMA, > following the scheme similar to that of IDE DMA. >=20 > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > --- > hw/ide/atapi.c | 13 ++++++------- > hw/ide/core.c | 30 +++++++++++++++--------------- > hw/ide/internal.h | 21 +++++++++++++++++++++ > hw/ide/macio.c | 2 ++ > 4 files changed, 44 insertions(+), 22 deletions(-)" >=20 > this letter was sent at "04/06/2016 09:40 AM" >=20 > Den Odd. Maybe because the "V4" tags were missing, it confused our patches tool? You're right, I don't see it in the mail itself, sorry. --js